18.0 pl consistency check final#10
Closed
alexis-via wants to merge 101 commits intoacsone:18.0-pl-consistency-check-pseudocode-sbifrom
Closed
18.0 pl consistency check final#10alexis-via wants to merge 101 commits intoacsone:18.0-pl-consistency-check-pseudocode-sbifrom
alexis-via wants to merge 101 commits intoacsone:18.0-pl-consistency-check-pseudocode-sbifrom
Conversation
…udget.by.account and mis.budget model and related views
When a user attempts to add a custom filter while previewing a report, the system throws an error related to the dialog service.
…rt style form view
Rational: without that widget, it's quite hard to know if all the brackets are correctly closed. the 'code' widget can help user avoid errors
rational: by default, a new style 'inherits' all the values. It is therefore the specifics values that describe a style. Adds a new 'description' char field, which concatenates all the specific values, available in the tree view, in order to facilitate style selection
Rational: in many MIS templates, some fields are not used. Allow to hide those fields to make lighter display
Rational: in many MIS templates, some fields are not used. Allow to hide those fields to make lighter display.
…any periods Rational: For the time being, copy_data is failing, if there are many periods in an mis.report.instance, because self.source only works with a singleton. Bug introduced in version 13.0, in OCA#343
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: mis-builder-18.0/mis-builder-18.0-mis_builder Translate-URL: https://translation.odoo-community.org/projects/mis-builder-18-0/mis-builder-18-0-mis_builder/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: mis-builder-18.0/mis-builder-18.0-mis_builder Translate-URL: https://translation.odoo-community.org/projects/mis-builder-18-0/mis-builder-18-0-mis_builder/
Rational: Before that commits, check (or uncheck) 'inherit' fields move all the other fields, in the report style form view. This is not the best User experience. With that commit, fields are allways in the same places, even if there are hidden
analytic_distribution_search has been removed in v18 and it was set on purpose on mis_builder migration scripts in 16.0. I think we need to handle it as well in 18.0 migration.
Currently translated at 100.0% (87 of 87 strings) Translation: mis-builder-18.0/mis-builder-18.0-mis_builder_budget Translate-URL: https://translation.odoo-community.org/projects/mis-builder-18-0/mis-builder-18-0-mis_builder_budget/it/
Currently translated at 100.0% (301 of 301 strings) Translation: mis-builder-18.0/mis-builder-18.0-mis_builder Translate-URL: https://translation.odoo-community.org/projects/mis-builder-18-0/mis-builder-18-0-mis_builder/it/
Use odoo float rounding instead of python. The rounding of pythons built-in may lead to unexpected results. For example, 9.25 round to 9.2. 9.75 is rounded to 9.8. It is unclear if the value gets round up or down.
Currently translated at 93.0% (280 of 301 strings) Translation: mis-builder-18.0/mis-builder-18.0-mis_builder Translate-URL: https://translation.odoo-community.org/projects/mis-builder-18-0/mis-builder-18-0-mis_builder/tr/
Currently translated at 100.0% (87 of 87 strings) Translation: mis-builder-18.0/mis-builder-18.0-mis_builder_budget Translate-URL: https://translation.odoo-community.org/projects/mis-builder-18-0/mis-builder-18-0-mis_builder_budget/sv/
Currently translated at 90.6% (273 of 301 strings) Translation: mis-builder-18.0/mis-builder-18.0-mis_builder Translate-URL: https://translation.odoo-community.org/projects/mis-builder-18-0/mis-builder-18-0-mis_builder/sv/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: mis-builder-18.0/mis-builder-18.0-mis_builder Translate-URL: https://translation.odoo-community.org/projects/mis-builder-18-0/mis-builder-18-0-mis_builder/
Currently translated at 100.0% (303 of 303 strings) Translation: mis-builder-18.0/mis-builder-18.0-mis_builder Translate-URL: https://translation.odoo-community.org/projects/mis-builder-18-0/mis-builder-18-0-mis_builder/it/
Currently translated at 94.3% (286 of 303 strings) Translation: mis-builder-18.0/mis-builder-18.0-mis_builder Translate-URL: https://translation.odoo-community.org/projects/mis-builder-18-0/mis-builder-18-0-mis_builder/sv/
Currently translated at 100.0% (303 of 303 strings) Translation: mis-builder-18.0/mis-builder-18.0-mis_builder Translate-URL: https://translation.odoo-community.org/projects/mis-builder-18-0/mis-builder-18-0-mis_builder/sv/
Currently translated at 100.0% (23 of 23 strings) Translation: mis-builder-18.0/mis-builder-18.0-mis_builder_demo Translate-URL: https://translation.odoo-community.org/projects/mis-builder-18-0/mis-builder-18-0-mis_builder_demo/it/
New field constraint_type on mis.report. If field 'constraint_type' is set, Odoo will check the MIS report template before displaying the report to the user.
Author
|
PR has been moved here: OCA#785 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
15 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Questions on this PR:
Where should we plug the constraint checks on mis.report.instance ?
At the moment, it is called when you click on the buttons "Preview" or "Print" or "Export". But it is not called when the report is in the dashboard. Which method should we inherit to perform checks in all circumstances ?
In v18, the display_name of an account depends on the company of the context. I use the display_name of accounts in error messages, but a MIS report template can apply to several companies. At the moment, I use the display_name of the first company of the MIS report template.
We could adds checks for the signs in the formula (cf TODO in comments).