Skip to content

Conversation

@Jym77
Copy link
Collaborator

@Jym77 Jym77 commented Sep 23, 2021

Explicitly fails the default name of image buttons. Explicitly accept default names of reset and submit buttons.

Closes issue(s):

Need for Call for Review:
This will require a 1 week Call for Review (small change to expectation)


Pull Request Etiquette

When creating PR:

  • Make sure you're requesting to pull a branch (right side) to the develop branch (left side).
  • Make sure you do not remove the "How to Review and Approve" section in your pull request description

After creating PR:

  • Add yourself (and co-authors) as "Assignees" for PR.
  • Add label to indicate if it's a Rule, Definition or Chore.
  • Link the PR to any issue it solves. This will be done automatically by referencing the issue at the top of this comment in the indicated place.
  • Optionally request feedback from anyone in particular by assigning them as "Reviewers".

When merging a PR:

  • Close any issue that the PR resolves. This will happen automatically upon merging if the PR was correctly linked to the issue, e.g. by referencing the issue at the top of this comment.

How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

@Jym77 Jym77 added Rule Update Use this label for an existing rule that is being updated reviewers wanted labels Sep 23, 2021
@Jym77 Jym77 self-assigned this Sep 23, 2021

## Background

Some elements have a role of `button` and a default accessible name defined by the [HTML Accessibility API Mapping][html aam input button], for example `input` elements whose `type` [attribute value][] is either `submit` or `reset`. This rule consider that these default names can be descriptive and therefore does not fail them.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Some elements have a role of `button` and a default accessible name defined by the [HTML Accessibility API Mapping][html aam input button], for example `input` elements whose `type` [attribute value][] is either `submit` or `reset`. This rule consider that these default names can be descriptive and therefore does not fail them.
Some elements have a role of `button` and a default accessible name defined by the [HTML Accessibility API Mapping][html aam input button], for example `input` elements whose `type` [attribute value][] is either `submit` or `reset`. This rule considers that these default names can be descriptive and therefore does not fail them.

Copy link
Collaborator

@tbostic32 tbostic32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small editorial and I think the second change may have been made to the wrong rule.

tbostic32
tbostic32 previously approved these changes Sep 23, 2021
WilcoFiers
WilcoFiers previously approved these changes Sep 28, 2021
Copy link
Member

@WilcoFiers WilcoFiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slight preference for Trevor's suggestion, but no objection to how you did this.

Copy link
Collaborator

@daniel-montalvo daniel-montalvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can live with this as is, but I also think this is more an assumption than a background comment really.

@Jym77 Jym77 dismissed stale reviews from tbostic32, daniel-montalvo, and WilcoFiers October 7, 2021 12:09

Moved note to assumption

@Jym77 Jym77 requested a review from WilcoFiers October 7, 2021 12:09
Co-authored-by: Trevor R. Bostic <32486143+tbostic32@users.noreply.github.com>
@Jym77 Jym77 added Review Call 1 week Call for review for small changes and removed reviewers wanted labels Nov 4, 2021
@Jym77
Copy link
Collaborator Author

Jym77 commented Nov 4, 2021

Call for Review ends on November 11th.

@Jym77
Copy link
Collaborator Author

Jym77 commented Nov 11, 2021

Final Call has ended. Merging.

@Jym77 Jym77 merged commit 02275ad into develop Nov 11, 2021
@Jym77 Jym77 deleted the image-button-accessible-name-fail-default-name branch November 11, 2021 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Review Call 1 week Call for review for small changes Rule Update Use this label for an existing rule that is being updated

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Image button has non-empty accessible name" (59796f) does not consider default names and all Failed Examples are actually passing…

8 participants