-
Notifications
You must be signed in to change notification settings - Fork 79
"Image button has non-empty accessible name" [59796f]: Fail default name ("Submit Query") #1717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Image button has non-empty accessible name" [59796f]: Fail default name ("Submit Query") #1717
Conversation
|
|
||
| ## Background | ||
|
|
||
| Some elements have a role of `button` and a default accessible name defined by the [HTML Accessibility API Mapping][html aam input button], for example `input` elements whose `type` [attribute value][] is either `submit` or `reset`. This rule consider that these default names can be descriptive and therefore does not fail them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Some elements have a role of `button` and a default accessible name defined by the [HTML Accessibility API Mapping][html aam input button], for example `input` elements whose `type` [attribute value][] is either `submit` or `reset`. This rule consider that these default names can be descriptive and therefore does not fail them. | |
| Some elements have a role of `button` and a default accessible name defined by the [HTML Accessibility API Mapping][html aam input button], for example `input` elements whose `type` [attribute value][] is either `submit` or `reset`. This rule considers that these default names can be descriptive and therefore does not fail them. |
tbostic32
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small editorial and I think the second change may have been made to the wrong rule.
WilcoFiers
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Slight preference for Trevor's suggestion, but no objection to how you did this.
daniel-montalvo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can live with this as is, but I also think this is more an assumption than a background comment really.
Moved note to assumption
|
Call for Review ends on November 11th. |
|
Final Call has ended. Merging. |
Explicitly fails the default name of image buttons. Explicitly accept default names of reset and submit buttons.
Closes issue(s):
Need for Call for Review:
This will require a 1 week Call for Review (small change to expectation)
Pull Request Etiquette
When creating PR:
developbranch (left side).After creating PR:
Rule,DefinitionorChore.When merging a PR:
How to Review And Approve