Skip to content

Conversation

kherr-a11y
Copy link
Collaborator

Removed the reference to tabindex="-`" from Assumptions, per ACT meeting survey discussion.
Removed second sentence from Expectation, per ACT meeting survey discussion
Added new pass example where iframe is hidden (not visible)

How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

@kherr-a11y kherr-a11y requested a review from tbostic32 January 12, 2022 14:44
@kherr-a11y kherr-a11y added the Rule Update Use this label for an existing rule that is being updated label Jan 12, 2022
@kherr-a11y
Copy link
Collaborator Author

@tbostic32 can you give this a first review?

@kherr-a11y kherr-a11y added Discussion and removed Rule Update Use this label for an existing rule that is being updated labels Jan 12, 2022
## Applicability

This rule applies to any `iframe` element that has a negative number as a `tabindex` [attribute value][].
This rule applies to any non-focusable `iframe` element that has focusable content.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you changing to non-focusable because its more clear or is there a scenario that the negative tab-index doesn't catch? Asking because I do somewhat like how specific the negative tab-index is.

Also, you will probably need to include a reference to focusable here. You should be able to add it by doing [focusable][]

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will probably also need to change the description of the rule to mirror this.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also going to explode violently with the change suggested to "focusable" by @carlosapaduarte in #1444 which explicitly says that element with negative tabindex are "focusable".

We could use "is not part of sequential focus navigation" (to replace negative tabindex)… but… Step 2 of the sequential navigation search algorithm explicitly skips over browsing context containers (i.e. iframe, mostly).

HelenBurge
HelenBurge previously approved these changes Jan 17, 2022
Copy link
Collaborator

@HelenBurge HelenBurge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with Trevor's feedback but nothing to add myself

## Applicability

This rule applies to any `iframe` element that has a negative number as a `tabindex` [attribute value][].
This rule applies to any non-focusable `iframe` element that has focusable content.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also going to explode violently with the change suggested to "focusable" by @carlosapaduarte in #1444 which explicitly says that element with negative tabindex are "focusable".

We could use "is not part of sequential focus navigation" (to replace negative tabindex)… but… Step 2 of the sequential navigation search algorithm explicitly skips over browsing context containers (i.e. iframe, mostly).

## Applicability

This rule applies to any `iframe` element that has a negative number as a `tabindex` [attribute value][].
This rule applies to any non-focusable `iframe` element that has focusable content.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm also not sure about adding "that has focusable content" in the Applicability. Skipping over the (lack of) definition of "has", this means that most Passed Example (e.g. Passed Example 1) are now Inapplicable, since the iframe has no focusable content 🤔

@HelenBurge HelenBurge self-assigned this Mar 3, 2022
@HelenBurge HelenBurge requested review from HelenBurge, Jym77 and tbostic32 and removed request for HelenBurge March 15, 2022 15:45
@HelenBurge HelenBurge dismissed their stale review March 15, 2022 15:46

As now working on it

@HelenBurge HelenBurge requested review from colabottles and removed request for HelenBurge March 15, 2022 15:46
@HelenBurge HelenBurge added the Review call 2 weeks Call for review for new rules and big changes label Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Review call 2 weeks Call for review for new rules and big changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants