-
Notifications
You must be signed in to change notification settings - Fork 78
Survey amendments iframe-not-focusable-has-no-interactive-content-akn7bn #1779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@tbostic32 can you give this a first review? |
## Applicability | ||
|
||
This rule applies to any `iframe` element that has a negative number as a `tabindex` [attribute value][]. | ||
This rule applies to any non-focusable `iframe` element that has focusable content. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you changing to non-focusable because its more clear or is there a scenario that the negative tab-index doesn't catch? Asking because I do somewhat like how specific the negative tab-index is.
Also, you will probably need to include a reference to focusable here. You should be able to add it by doing [focusable][]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You will probably also need to change the description of the rule to mirror this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is also going to explode violently with the change suggested to "focusable" by @carlosapaduarte in #1444 which explicitly says that element with negative tabindex
are "focusable".
We could use "is not part of sequential focus navigation" (to replace negative tabindex
)… but… Step 2 of the sequential navigation search algorithm explicitly skips over browsing context containers (i.e. iframe
, mostly).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with Trevor's feedback but nothing to add myself
## Applicability | ||
|
||
This rule applies to any `iframe` element that has a negative number as a `tabindex` [attribute value][]. | ||
This rule applies to any non-focusable `iframe` element that has focusable content. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is also going to explode violently with the change suggested to "focusable" by @carlosapaduarte in #1444 which explicitly says that element with negative tabindex
are "focusable".
We could use "is not part of sequential focus navigation" (to replace negative tabindex
)… but… Step 2 of the sequential navigation search algorithm explicitly skips over browsing context containers (i.e. iframe
, mostly).
## Applicability | ||
|
||
This rule applies to any `iframe` element that has a negative number as a `tabindex` [attribute value][]. | ||
This rule applies to any non-focusable `iframe` element that has focusable content. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm also not sure about adding "that has focusable content" in the Applicability. Skipping over the (lack of) definition of "has", this means that most Passed Example (e.g. Passed Example 1) are now Inapplicable, since the iframe
has no focusable content 🤔
_rules/iframe-not-focusable-has-no-interactive-content-akn7bn.md
Outdated
Show resolved
Hide resolved
_rules/iframe-not-focusable-has-no-interactive-content-akn7bn.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com>
Removed the reference to tabindex="-`" from Assumptions, per ACT meeting survey discussion.
Removed second sentence from Expectation, per ACT meeting survey discussion
Added new pass example where iframe is hidden (not visible)
How to Review And Approve