-
Notifications
You must be signed in to change notification settings - Fork 79
b4f0c3: Adjust meta viewport applicability based on properties defined #1835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HelenBurge
approved these changes
Apr 26, 2022
WilcoFiers
approved these changes
Apr 28, 2022
WilcoFiers
previously requested changes
Apr 28, 2022
Member
WilcoFiers
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, would you mind merging these changes in too. They're part of another change we wanted to make. This avoids merge conflicts.
Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
daniel-montalvo
previously approved these changes
May 2, 2022
Jym77
previously requested changes
May 12, 2022
colabottles
approved these changes
May 26, 2022
HelenBurge
approved these changes
May 26, 2022
carlosapaduarte
previously requested changes
May 30, 2022
Co-authored-by: Carlos Duarte <carlosapaduarte@gmail.com>
Jym77
approved these changes
Jun 2, 2022
As agreed, dismissing your review
WilcoFiers
requested changes
Jun 3, 2022
Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
carlosapaduarte
approved these changes
Jun 3, 2022
WilcoFiers
approved these changes
Jun 6, 2022
WilcoFiers
approved these changes
Jun 7, 2022
colabottles
approved these changes
Jun 9, 2022
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Review Call 1 week
Call for review for small changes
Rule Update
Use this label for an existing rule that is being updated
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust the applicability of the rule to be more narrow and only apply to meta elements whose content attributes defines one of the affected values. Move Pass 1 and Pass 4 to the N/A section since these examples do not define these attributes. Discussed briefly in taskforce call April 14.
Closes issue(s):
Need for Call for Review: 1 week
Pull Request Etiquette
When creating PR:
developbranch (left side).After creating PR:
Rule,DefinitionorChore.When merging a PR:
How to Review And Approve