Skip to content

Conversation

@tombrunet
Copy link
Collaborator

@tombrunet tombrunet commented Apr 19, 2022

Adjust the applicability of the rule to be more narrow and only apply to meta elements whose content attributes defines one of the affected values. Move Pass 1 and Pass 4 to the N/A section since these examples do not define these attributes. Discussed briefly in taskforce call April 14.

Closes issue(s):

Need for Call for Review: 1 week


Pull Request Etiquette

When creating PR:

  • Make sure you're requesting to pull a branch (right side) to the develop branch (left side).
  • Make sure you do not remove the "How to Review and Approve" section in your pull request description

After creating PR:

  • Add yourself (and co-authors) as "Assignees" for PR.
  • Add label to indicate if it's a Rule, Definition or Chore.
  • Link the PR to any issue it solves. This will be done automatically by referencing the issue at the top of this comment in the indicated place.
  • Optionally request feedback from anyone in particular by assigning them as "Reviewers".

When merging a PR:

  • Close any issue that the PR resolves. This will happen automatically upon merging if the PR was correctly linked to the issue, e.g. by referencing the issue at the top of this comment.

How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

@tombrunet tombrunet added the Rule Update Use this label for an existing rule that is being updated label Apr 19, 2022
@tombrunet tombrunet self-assigned this Apr 19, 2022
Copy link
Member

@WilcoFiers WilcoFiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, would you mind merging these changes in too. They're part of another change we wanted to make. This avoids merge conflicts.

Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
daniel-montalvo
daniel-montalvo previously approved these changes May 2, 2022
Jym77
Jym77 previously requested changes May 12, 2022
@tombrunet tombrunet requested review from Jym77 and WilcoFiers May 26, 2022 02:48
@WilcoFiers WilcoFiers dismissed stale reviews from Jym77 and themself May 26, 2022 13:08

Updated

tombrunet and others added 2 commits June 1, 2022 21:47
Co-authored-by: Carlos Duarte <carlosapaduarte@gmail.com>
@WilcoFiers WilcoFiers dismissed carlosapaduarte’s stale review June 3, 2022 11:44

As agreed, dismissing your review

Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
@tombrunet tombrunet requested a review from WilcoFiers June 3, 2022 13:32
@WilcoFiers WilcoFiers added the Review Call 1 week Call for review for small changes label Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Review Call 1 week Call for review for small changes Rule Update Use this label for an existing rule that is being updated

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants