Skip to content

Remove the unsupported --matrix flag from wai-build#1870

Merged
WilcoFiers merged 1 commit intodevelopfrom
update-act-tools-action
Jun 21, 2022
Merged

Remove the unsupported --matrix flag from wai-build#1870
WilcoFiers merged 1 commit intodevelopfrom
update-act-tools-action

Conversation

@WilcoFiers
Copy link
Copy Markdown
Member

I'm working on a PR that dynamically adds the implementation tables to the bottom of each rule page:
https://github.com/w3c/wcag-act-rules/pull/116/files

We're not going to need the --matrix flag anymore.

Need for Call for Review: none


Pull Request Etiquette

When creating PR:

  • Make sure you're requesting to pull a branch (right side) to the develop branch (left side).
  • Make sure you do not remove the "How to Review and Approve" section in your pull request description

After creating PR:

  • Add yourself (and co-authors) as "Assignees" for PR.
  • Add label to indicate if it's a Rule, Definition or Chore.
  • Link the PR to any issue it solves. This will be done automatically by referencing the issue at the top of this comment in the indicated place.
  • Optionally request feedback from anyone in particular by assigning them as "Reviewers".

When merging a PR:

  • Close any issue that the PR resolves. This will happen automatically upon merging if the PR was correctly linked to the issue, e.g. by referencing the issue at the top of this comment.

How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

@WilcoFiers WilcoFiers merged commit df2f24c into develop Jun 21, 2022
@WilcoFiers WilcoFiers deleted the update-act-tools-action branch June 21, 2022 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants