Skip to content

Fix git+ssh on wai-deploy#1872

Merged
WilcoFiers merged 1 commit intodevelopfrom
git-ssh-fix
Jun 21, 2022
Merged

Fix git+ssh on wai-deploy#1872
WilcoFiers merged 1 commit intodevelopfrom
git-ssh-fix

Conversation

@WilcoFiers
Copy link
Copy Markdown
Member

@WilcoFiers WilcoFiers commented Jun 21, 2022

I broke the release script. This fixes it

Need for Call for Review: none


How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

@WilcoFiers WilcoFiers force-pushed the git-ssh-fix branch 4 times, most recently from 40f94bf to b6fdb0d Compare June 21, 2022 12:56
@WilcoFiers WilcoFiers marked this pull request as ready for review June 21, 2022 13:12
key: ${{ runner.os }}-node-${{ hashFiles('**/package-lock.json') }}
restore-keys: |
${{ runner.os }}-node-
- run: git config --global url."https://github.com/".insteadOf ssh://git@github.com/
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to combine this with the credential setup on line 27. Couldn't figure it out so I'll just make the call twice.

@WilcoFiers WilcoFiers merged commit cf612b9 into develop Jun 21, 2022
@WilcoFiers WilcoFiers deleted the git-ssh-fix branch June 21, 2022 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants