-
Notifications
You must be signed in to change notification settings - Fork 78
Update headers attribute refer to data cells ensuring ancestor table has a role of table grid or treegrid #1968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
WilcoFiers
merged 6 commits into
act-rules:develop
from
giacomo-petri:giacomo-petri-headers-attribute-in-table-1
Dec 7, 2022
Merged
Update headers attribute refer to data cells ensuring ancestor table has a role of table grid or treegrid #1968
WilcoFiers
merged 6 commits into
act-rules:develop
from
giacomo-petri:giacomo-petri-headers-attribute-in-table-1
Dec 7, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@giacomo-petri we're updating the applicability of the rule, therefore the call for review should be for 2 weeks |
WilcoFiers
previously requested changes
Nov 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple small formatting tweaks. Rest looks good.
Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
Jym77
approved these changes
Nov 24, 2022
(test fails due to the missing |
Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com>
HelenBurge
approved these changes
Nov 24, 2022
carlosapaduarte
approved these changes
Nov 29, 2022
WilcoFiers
approved these changes
Dec 1, 2022
colabottles
approved these changes
Dec 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses the issue raised by @WilcoFiers, ensuring that headers attributes specified on a cell refers to cells in the same table element, when the table element has a role of table, grid or treegrid:
Closes issue(s):
Need for Call for Review:
This will require a 2 week Call for Review
Pull Request Etiquette
When creating PR:
develop
branch (left side).After creating PR:
Rule
,Definition
orChore
.When merging a PR:
How to Review And Approve