Skip to content

Conversation

giacomo-petri
Copy link
Collaborator

@giacomo-petri giacomo-petri commented Nov 10, 2022

This pull request addresses the issue raised by @WilcoFiers, ensuring that headers attributes specified on a cell refers to cells in the same table element, when the table element has a role of table, grid or treegrid:

  • added specific point about role in applicability;
  • added specific inapplicable example.

Closes issue(s):

Need for Call for Review:
This will require a 2 week Call for Review


Pull Request Etiquette

When creating PR:

  • Make sure you're requesting to pull a branch (right side) to the develop branch (left side).
  • Make sure you do not remove the "How to Review and Approve" section in your pull request description

After creating PR:

  • Add yourself (and co-authors) as "Assignees" for PR.
  • Add label to indicate if it's a Rule, Definition or Chore.
  • Link the PR to any issue it solves. This will be done automatically by referencing the issue at the top of this comment in the indicated place.
  • Optionally request feedback from anyone in particular by assigning them as "Reviewers".

When merging a PR:

  • Close any issue that the PR resolves. This will happen automatically upon merging if the PR was correctly linked to the issue, e.g. by referencing the issue at the top of this comment.

How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

@carlosapaduarte
Copy link
Member

@giacomo-petri we're updating the applicability of the rule, therefore the call for review should be for 2 weeks

Copy link
Member

@WilcoFiers WilcoFiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple small formatting tweaks. Rest looks good.

Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
@Jym77
Copy link
Collaborator

Jym77 commented Nov 24, 2022

(test fails due to the missing [semantic role]: #semantic-role 'Definition of semantic role' in the references list)

Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com>
@HelenBurge HelenBurge dismissed WilcoFiers’s stale review November 24, 2022 14:17

As the changes were done

@WilcoFiers WilcoFiers added the Review Call 1 week Call for review for small changes label Dec 1, 2022
@WilcoFiers WilcoFiers merged commit 1297e12 into act-rules:develop Dec 7, 2022
@giacomo-petri giacomo-petri deleted the giacomo-petri-headers-attribute-in-table-1 branch December 7, 2022 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Review Call 1 week Call for review for small changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Headers attribute rule should skip non-table roles [a25f45]

6 participants