Skip to content

Conversation

@tbostic32
Copy link
Collaborator

@tbostic32 tbostic32 commented Dec 12, 2022

First cut at updates to the video element auditory content has captions rule. Includes:

  • Update to applicability to remove silence
  • Update to test case descriptions
  • Replace "baked in" with "open captions"

TODO: There are concerns the rule is too strict and requiring captions for things that do not need them. Per the definition of captions, "only information needed to understand the media content". This opens the door for content in the video that is purely peripheral, as well as content that is self explained in the video (e.g., a stop sign).

Need for Call for Review:
This will require a 1 week Call for Review


Pull Request Etiquette

When creating PR:

  • Make sure you're requesting to pull a branch (right side) to the develop branch (left side).
  • Make sure you do not remove the "How to Review and Approve" section in your pull request description

After creating PR:

  • Add yourself (and co-authors) as "Assignees" for PR.
  • Add label to indicate if it's a Rule, Definition or Chore.
  • Link the PR to any issue it solves. This will be done automatically by referencing the issue at the top of this comment in the indicated place.
  • Optionally request feedback from anyone in particular by assigning them as "Reviewers".

When merging a PR:

  • Close any issue that the PR resolves. This will happen automatically upon merging if the PR was correctly linked to the issue, e.g. by referencing the issue at the top of this comment.

How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

First cut at updates to the video element auditory content has captions rule. Includes:
- Update to applicability to remove silence
- Update to test case descriptions
- Replace "baked in" with "open captions"
@carlosapaduarte
Copy link
Member

TODO: There are concerns the rule is too strict and requiring captions for things that do not need them. Per the definition of captions, "only information needed to understand the media content". This opens the door for content in the video that is purely peripheral, as well as content that is self explained in the video (e.g., a stop sign).

I'm not sure I understand this concern. The expectation requires captions for "audio information that is not conveyed visually in the video". A stop sign is not "audio information". A clip showing a stop sign while a narrator speaks "stop sign" would pass even without caption because the information is conveyed visually in the video.

And deciding what audio content is peripheral or not will always be controversial, I guess.

@giacomo-petri
Copy link
Collaborator

I cannot propose a change for this specific snippet of code but, in "Failed Example 4" there is a typo issue; we should replace ariadescribedby="text" with aria-describedby="text"

@tbostic32 tbostic32 merged commit e816cf5 into develop Feb 2, 2023
@tbostic32 tbostic32 deleted the tbostic32-video-element-captions branch February 2, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants