-
Notifications
You must be signed in to change notification settings - Fork 78
Add low-level fails to AAA rules #2010
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not fully sure I understand how this impact the consistency, but there is certainly no problems with getting these example back now.
@Jym77 What this does is it lets implementors split the implementation of this rule between the level AA part, and the level AAA part. If you have two contrast procedures in your tool; The first fails things below 4.5:1, the second fails things between 4.5:1 and 7:1, then the combination of those two procedures should be consistent with the AAA rule. In practice that means that we need to trigger at least one AA procedure with a failed example, otherwise it isn't part of the mapping. It's sort of like if the Button has name rule only had example of native buttons. If your implementation split tested native buttons separately from ARIA buttons, then the ARIA button rule wouldn't be mapped, even though it should be. In our case we needed the AA color-contrast procedure to get triggered so we can include the cantTells. Those are intentionally not included on the AAA procedure to avoid duplicates. |
Thanks, that's the bit I missed. Makes perfect sense 😄 |
This is a partial revert of #1958, now that secondary requirements have been added to AAA rules (#1986) we need to make sure that they always include an example of failing any lower-level success criterion. I went through all AAA rules, some of them have these examples. These two did not.
I'm listing this as a priority issue since for axe-core this impacts the consistency on Color Contrast (enhanced).
Need for Call for Review: 1 week
How to Review And Approve