Skip to content

Conversation

WilcoFiers
Copy link
Member

@WilcoFiers WilcoFiers commented Jan 18, 2023

This is a partial revert of #1958, now that secondary requirements have been added to AAA rules (#1986) we need to make sure that they always include an example of failing any lower-level success criterion. I went through all AAA rules, some of them have these examples. These two did not.

I'm listing this as a priority issue since for axe-core this impacts the consistency on Color Contrast (enhanced).

Need for Call for Review: 1 week


How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

Copy link
Collaborator

@Jym77 Jym77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not fully sure I understand how this impact the consistency, but there is certainly no problems with getting these example back now.

@WilcoFiers WilcoFiers added Review Call 1 week Call for review for small changes and removed reviewers wanted labels Jan 19, 2023
@WilcoFiers
Copy link
Member Author

@Jym77 What this does is it lets implementors split the implementation of this rule between the level AA part, and the level AAA part. If you have two contrast procedures in your tool; The first fails things below 4.5:1, the second fails things between 4.5:1 and 7:1, then the combination of those two procedures should be consistent with the AAA rule. In practice that means that we need to trigger at least one AA procedure with a failed example, otherwise it isn't part of the mapping.

It's sort of like if the Button has name rule only had example of native buttons. If your implementation split tested native buttons separately from ARIA buttons, then the ARIA button rule wouldn't be mapped, even though it should be.

In our case we needed the AA color-contrast procedure to get triggered so we can include the cantTells. Those are intentionally not included on the AAA procedure to avoid duplicates.

@Jym77
Copy link
Collaborator

Jym77 commented Jan 20, 2023

In our case we needed the AA color-contrast procedure to get triggered so we can include the cantTells. Those are intentionally not included on the AAA procedure to avoid duplicates.

Thanks, that's the bit I missed. Makes perfect sense 😄

@WilcoFiers WilcoFiers merged commit 3ba243f into develop Jan 26, 2023
@WilcoFiers WilcoFiers deleted the lower-lvl-failed-examples branch January 26, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority Review Call 1 week Call for review for small changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants