Skip to content

Various editorial tweaks to heading-descriptive#2128

Merged
WilcoFiers merged 3 commits intodevelopfrom
WilcoFiers-patch-1
Oct 25, 2023
Merged

Various editorial tweaks to heading-descriptive#2128
WilcoFiers merged 3 commits intodevelopfrom
WilcoFiers-patch-1

Conversation

@WilcoFiers
Copy link
Copy Markdown
Member

Need for Call for Review: none, editorial changes


How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

#### Failed Example 1

Heading marked up with `h1` element that does not describe the topic or purpose of the following [perceivable content][].
This `h1` heading element does not describes the topic of the following paragraph.
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This `h1` heading element does not describes the topic of the following paragraph.
This `h1` heading element does not describe the topic of the following paragraph.

Copy link
Copy Markdown
Collaborator

@kengdoj kengdoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just made one suggestion

@WilcoFiers WilcoFiers merged commit 09d15b6 into develop Oct 25, 2023
@WilcoFiers WilcoFiers deleted the WilcoFiers-patch-1 branch October 25, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants