Refactor: Standardize Firebase Storage bucket names and upload paths#202
Merged
kumarpalsinh25 merged 1 commit intomainfrom Dec 23, 2025
Merged
Refactor: Standardize Firebase Storage bucket names and upload paths#202kumarpalsinh25 merged 1 commit intomainfrom
kumarpalsinh25 merged 1 commit intomainfrom
Conversation
This commit refactors the Firebase Storage implementation to use a more standardized and hierarchical structure. Key changes include: - A new `subFolderName` parameter has been added to the `uploadFileToStorage` utility function to allow for more organized file paths within buckets. - The `userId` parameter has been removed from `uploadFileToStorage`, making the function more generic. The user ID can now be passed as a `subFolderName`. - Storage bucket names in `FirestoreBucketNames` have been consolidated. `userAvatars` is now simply `users`, and new constants for `sheets`, `sheetBanners`, and `documents` have been added for future use. - The user avatar upload logic in `user_providers.dart` has been updated to use the new `users` bucket and pass the user ID as a `subFolderName`.
|
Caution Review failedThe pull request is closed. WalkthroughThis change refactors Firebase storage path management by removing the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes ✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Dec 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit refactors the Firebase Storage implementation to use a more standardized and hierarchical structure.
Key changes include:
subFolderNameparameter has been added to theuploadFileToStorageutility function to allow for more organized file paths within buckets.userIdparameter has been removed fromuploadFileToStorage, making the function more generic. The user ID can now be passed as asubFolderName.FirestoreBucketNameshave been consolidated.userAvatarsis now simplyusers, and new constants forsheets,sheetBanners, anddocumentshave been added for future use.user_providers.darthas been updated to use the newusersbucket and pass the user ID as asubFolderName.Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.