[codex] cli: keep setup and switch its browser modes to local/cloud#455
Merged
mcfn merged 5 commits intorelease/1.0.0from Apr 2, 2026
Merged
[codex] cli: keep setup and switch its browser modes to local/cloud#455mcfn merged 5 commits intorelease/1.0.0from
mcfn merged 5 commits intorelease/1.0.0from
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 192905515f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
actionbook setupcommand availablelocal|cloudand rejectextensioninside setupWhy
The setup command itself should remain available. The actual change needed here was narrower: inside setup, the supported browser modes are
local|cloud, andextensionshould no longer be accepted as a real setup mode.Impact
Users can still run
actionbook setup, and top-level help still lists it as an available command. Within setup,--browser extensionis rejected, whilelocalandcloudare the supported setup modes. Existing cloud configs continue through setup without being treated as unsupported.Validation
cargo test try_parse_from_parses_setup_non_interactive_flags --lib -- --nocapturecargo test top_level_help_lists_setup_command --test help_cli -- --nocapturecargo test parse_browser_flag_rejects_extension -- --nocapturecargo test setup_extension_browser_value_exits_non_zero --test setup_cli -- --nocapturecargo test parse_browser_flag_accepts_supported_values -- --nocapturecargo test setup_json_non_interactive_cloud_mode_writes_config_without_daemon_side_effects --test setup_cli -- --nocapturecargo test setup_non_interactive_existing_cloud_config_is_preserved --test setup_cli -- --nocapturecargo test --lib setup:: -- --nocaptureNotes
cargo test --test setup_cli -- --nocapturestill reports one pre-existing failure around env API key persistence that was outside this change.