Skip to content

[codex] cli: keep setup and switch its browser modes to local/cloud#455

Merged
mcfn merged 5 commits intorelease/1.0.0from
codex/cli-setup-local-cloud-mode
Apr 2, 2026
Merged

[codex] cli: keep setup and switch its browser modes to local/cloud#455
mcfn merged 5 commits intorelease/1.0.0from
codex/cli-setup-local-cloud-mode

Conversation

@mcfn
Copy link
Copy Markdown
Contributor

@mcfn mcfn commented Apr 2, 2026

Summary

  • keep the actionbook setup command available
  • switch the setup browser-mode contract to local|cloud and reject extension inside setup
  • preserve supported cloud configs during setup reruns and update setup-focused regression coverage

Why

The setup command itself should remain available. The actual change needed here was narrower: inside setup, the supported browser modes are local|cloud, and extension should no longer be accepted as a real setup mode.

Impact

Users can still run actionbook setup, and top-level help still lists it as an available command. Within setup, --browser extension is rejected, while local and cloud are the supported setup modes. Existing cloud configs continue through setup without being treated as unsupported.

Validation

  • cargo test try_parse_from_parses_setup_non_interactive_flags --lib -- --nocapture
  • cargo test top_level_help_lists_setup_command --test help_cli -- --nocapture
  • cargo test parse_browser_flag_rejects_extension -- --nocapture
  • cargo test setup_extension_browser_value_exits_non_zero --test setup_cli -- --nocapture
  • cargo test parse_browser_flag_accepts_supported_values -- --nocapture
  • cargo test setup_json_non_interactive_cloud_mode_writes_config_without_daemon_side_effects --test setup_cli -- --nocapture
  • cargo test setup_non_interactive_existing_cloud_config_is_preserved --test setup_cli -- --nocapture
  • cargo test --lib setup:: -- --nocapture

Notes

  • cargo test --test setup_cli -- --nocapture still reports one pre-existing failure around env API key persistence that was outside this change.

@mcfn mcfn changed the base branch from main to release/1.0.0 April 2, 2026 08:06
@mcfn mcfn changed the title [codex] cli: rename setup isolated mode to local [codex] cli: switch setup browser modes to local/cloud Apr 2, 2026
@mcfn mcfn changed the title [codex] cli: switch setup browser modes to local/cloud [codex] cli: update browser setup flow and mark setup coming soon Apr 2, 2026
@mcfn mcfn changed the title [codex] cli: update browser setup flow and mark setup coming soon [codex] cli: keep setup and switch its browser modes to local/cloud Apr 2, 2026
@mcfn mcfn marked this pull request as ready for review April 2, 2026 08:38
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 192905515f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@mcfn mcfn merged commit 7cbff7f into release/1.0.0 Apr 2, 2026
4 checks passed
@mcfn mcfn deleted the codex/cli-setup-local-cloud-mode branch April 2, 2026 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant