feat: wire channels through pipeline, remove dead code, add metadata version#7
Merged
Merged
Conversation
Replace VisibilityFilter with ChannelManifestFilter that uses ChannelManifest.resolve() for policy-based filtering. Pass manifest to pipeline deps so resolveChannels() and passesStageConstraint() can route per-document channels to the publisher.
… methods Remove ReleaseManifest class (superseded by ChannelManifest), Visibility enum (no production references), VisibilityFilter (replaced by ChannelManifestFilter), isPublic() and resolveStageAllowList() bridge methods from ChannelManifest. Update all tests to use resolve().
Add version: 1 to ReleaseMetadataJson for format negotiation by downstream consumers. Add a warning log when resolveSourcePath() cannot find a /documents/ segment in the output directory path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Completes the channel-based publication wiring from the audit (TODO 15, items A–K):
What changed
Channel pipeline wiring (audit A, F, G)
VisibilityFilterwithChannelManifestFilterthat usesChannelManifest.resolve()for policy-based filteringmanifestto pipeline deps soresolveChannels()andpassesStageConstraint()route per-document channels to the publisherDead code removal (audit B, C, D, E)
ReleaseManifestclass (superseded byChannelManifest)Visibilityenum (no production references)VisibilityFilter(replaced byChannelManifestFilter)isPublic()andresolveStageAllowList()bridge methods fromChannelManifestresolve()instead ofisPublic()Metadata & robustness (audit H, I)
version: 1toReleaseMetadataJsonfor format negotiation by downstream consumersresolveSourcePath()cannot find a/documents/segmentO(n²) fix (audit J) — already in place from prior work, verified no
indexOfin pipelineTest plan
channel-manifest-filter.test.tswith 5 tests covering the filterpipeline.test.ts,channel-manifest.test.ts,manifest-loader.test.tsto use new APIsrelease-manifest.test.tsandvisibility-filter.test.ts