refactor: migrate to ESM + esbuild from @vercel/ncc#28
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
ronaldtse
force-pushed
the
feat/esm-esbuild-migration
branch
from
35cf48b to
8cb75c2
Compare
- Add explicit permissions to check-dist.yml workflow - Add semver validation for version input to prevent command injection - Fix vitest to use run mode instead of watch mode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR migrates the GitHub Action from CommonJS + @vercel/ncc to ESM + esbuild, following the same pattern used in the site-gen action.
Changes
Build System
Dependencies Updated
@actions/core: v1.x → v3.0.0 (now uses named exports)@actions/exec: v1.x → v3.0.0@actions/tool-cache: v1.x → v3.0.0@actions/io: v1.x → v3.0.2vitest: v2.x → v3.2.4typescript: v5.5 → v5.8.3esbuild: added v0.25.2@vercel/ncc: removedTypeScript Configuration
module: "commonjs" → "ESNext"moduleResolution: "bundler"verbatimModuleSyntax: truefor explicit type importsSource Code Updates
.jsextensions to all relative importsimport typefor type-only importsBenefits
Test Results
All 118 tests pass.
Test plan
npm run buildnpm test