Allow users to apply labels and annotations to internal resources#4400
Merged
nikola-jokic merged 10 commits intomasterfrom Mar 12, 2026
Merged
Allow users to apply labels and annotations to internal resources#4400nikola-jokic merged 10 commits intomasterfrom
nikola-jokic merged 10 commits intomasterfrom
Conversation
Contributor
|
Hello! Thank you for your contribution. Please review our contribution guidelines to understand the project's testing and code conventions. |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for specifying per-internal-resource labels/annotations via new ResourceMeta fields on AutoscalingRunnerSet / AutoscalingListener / EphemeralRunner(Set) APIs, and wires that metadata into the controller’s resource builder (with accompanying CRD updates).
Changes:
- Introduce
ResourceMetaAPI type and new spec fields to carry labels/annotations for internal resources. - Apply the new metadata in
ResourceBuilderwhen creating listener/runner internal resources. - Regenerate/update CRDs (repo config + Helm chart packaged CRDs) and expand unit tests for propagation.
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 14 comments.
Show a summary per file
| File | Description |
|---|---|
| controllers/actions.github.com/resourcebuilder.go | Applies metadata to listener/runner internal resources; adds new merge helpers |
| controllers/actions.github.com/resourcebuilder_test.go | Expands propagation test to cover new metadata fields |
| apis/actions.github.com/v1alpha1/common.go | Adds ResourceMeta type |
| apis/actions.github.com/v1alpha1/autoscalingrunnerset_types.go | Adds new metadata fields to AutoscalingRunnerSetSpec |
| apis/actions.github.com/v1alpha1/autoscalinglistener_types.go | Adds new metadata fields to AutoscalingListenerSpec |
| apis/actions.github.com/v1alpha1/ephemeralrunnerset_types.go | Adds EphemeralRunner metadata field |
| apis/actions.github.com/v1alpha1/ephemeralrunner_types.go | Adds EphemeralRunner JIT secret metadata field |
| apis/actions.github.com/v1alpha1/zz_generated.deepcopy.go | Updates deepcopy generation for new fields/types |
| config/crd/bases/actions.github.com_autoscalingrunnersets.yaml | CRD schema update for new fields |
| config/crd/bases/actions.github.com_autoscalinglisteners.yaml | CRD schema update for new fields |
| config/crd/bases/actions.github.com_ephemeralrunnersets.yaml | CRD schema update for new fields |
| config/crd/bases/actions.github.com_ephemeralrunners.yaml | CRD schema update for new fields |
| charts/gha-runner-scale-set-controller/crds/actions.github.com_autoscalingrunnersets.yaml | Packaged chart CRD schema update |
| charts/gha-runner-scale-set-controller/crds/actions.github.com_autoscalinglisteners.yaml | Packaged chart CRD schema update |
| charts/gha-runner-scale-set-controller/crds/actions.github.com_ephemeralrunnersets.yaml | Packaged chart CRD schema update |
| charts/gha-runner-scale-set-controller/crds/actions.github.com_ephemeralrunners.yaml | Packaged chart CRD schema update |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
charts/gha-runner-scale-set-controller/crds/actions.github.com_autoscalinglisteners.yaml
Outdated
Show resolved
Hide resolved
charts/gha-runner-scale-set-controller/crds/actions.github.com_ephemeralrunners.yaml
Outdated
Show resolved
Hide resolved
charts/gha-runner-scale-set-controller/crds/actions.github.com_autoscalingrunnersets.yaml
Outdated
Show resolved
Hide resolved
charts/gha-runner-scale-set-controller/crds/actions.github.com_ephemeralrunnersets.yaml
Outdated
Show resolved
Hide resolved
rentziass
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4293