Skip to content

Allow users to apply labels and annotations to internal resources#4400

Merged
nikola-jokic merged 10 commits intomasterfrom
nikola-jokic/internal-resource-customizations
Mar 12, 2026
Merged

Allow users to apply labels and annotations to internal resources#4400
nikola-jokic merged 10 commits intomasterfrom
nikola-jokic/internal-resource-customizations

Conversation

@nikola-jokic
Copy link
Collaborator

Fixes #4293

Copilot AI review requested due to automatic review settings March 9, 2026 20:01
@nikola-jokic nikola-jokic added the gha-runner-scale-set Related to the gha-runner-scale-set mode label Mar 9, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2026

Hello! Thank you for your contribution.

Please review our contribution guidelines to understand the project's testing and code conventions.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support for specifying per-internal-resource labels/annotations via new ResourceMeta fields on AutoscalingRunnerSet / AutoscalingListener / EphemeralRunner(Set) APIs, and wires that metadata into the controller’s resource builder (with accompanying CRD updates).

Changes:

  • Introduce ResourceMeta API type and new spec fields to carry labels/annotations for internal resources.
  • Apply the new metadata in ResourceBuilder when creating listener/runner internal resources.
  • Regenerate/update CRDs (repo config + Helm chart packaged CRDs) and expand unit tests for propagation.

Reviewed changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated 14 comments.

Show a summary per file
File Description
controllers/actions.github.com/resourcebuilder.go Applies metadata to listener/runner internal resources; adds new merge helpers
controllers/actions.github.com/resourcebuilder_test.go Expands propagation test to cover new metadata fields
apis/actions.github.com/v1alpha1/common.go Adds ResourceMeta type
apis/actions.github.com/v1alpha1/autoscalingrunnerset_types.go Adds new metadata fields to AutoscalingRunnerSetSpec
apis/actions.github.com/v1alpha1/autoscalinglistener_types.go Adds new metadata fields to AutoscalingListenerSpec
apis/actions.github.com/v1alpha1/ephemeralrunnerset_types.go Adds EphemeralRunner metadata field
apis/actions.github.com/v1alpha1/ephemeralrunner_types.go Adds EphemeralRunner JIT secret metadata field
apis/actions.github.com/v1alpha1/zz_generated.deepcopy.go Updates deepcopy generation for new fields/types
config/crd/bases/actions.github.com_autoscalingrunnersets.yaml CRD schema update for new fields
config/crd/bases/actions.github.com_autoscalinglisteners.yaml CRD schema update for new fields
config/crd/bases/actions.github.com_ephemeralrunnersets.yaml CRD schema update for new fields
config/crd/bases/actions.github.com_ephemeralrunners.yaml CRD schema update for new fields
charts/gha-runner-scale-set-controller/crds/actions.github.com_autoscalingrunnersets.yaml Packaged chart CRD schema update
charts/gha-runner-scale-set-controller/crds/actions.github.com_autoscalinglisteners.yaml Packaged chart CRD schema update
charts/gha-runner-scale-set-controller/crds/actions.github.com_ephemeralrunnersets.yaml Packaged chart CRD schema update
charts/gha-runner-scale-set-controller/crds/actions.github.com_ephemeralrunners.yaml Packaged chart CRD schema update

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@nikola-jokic nikola-jokic merged commit 1d9f626 into master Mar 12, 2026
20 checks passed
@nikola-jokic nikola-jokic deleted the nikola-jokic/internal-resource-customizations branch March 12, 2026 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gha-runner-scale-set Related to the gha-runner-scale-set mode

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Listener ServiceAccount does not allow to add Annotations

3 participants