Open
Conversation
nikola-jokic
added
the
gha-runner-scale-set
nikola-jokic
requested review from
a team,
Steve-Glass,
rentziass and
toast-gear
as code owners
Contributor
|
Hello! Thank you for your contribution. Please review our contribution guidelines to understand the project's testing and code conventions. |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates CRD additional printer columns to reflect the .status.state → .status.phase rename so kubectl get outputs show the correct phase values (fixes #4463).
Changes:
- Switch AutoscalingRunnerSet printer column JSONPath from
.status.stateto.status.phaseand rename column label to “Phase”. - Rename EphemeralRunner printer column label from “Status” to “Phase” (still pointing at
.status.phase). - Add a “Phase” printer column to EphemeralRunnerSet CRDs across base manifests and both Helm charts.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| config/crd/bases/actions.github.com_ephemeralrunnersets.yaml | Adds Phase additional printer column for EphemeralRunnerSet. |
| config/crd/bases/actions.github.com_ephemeralrunners.yaml | Renames printer column label to Phase for .status.phase. |
| config/crd/bases/actions.github.com_autoscalingrunnersets.yaml | Fixes printer column JSONPath to .status.phase and label to Phase. |
| charts/gha-runner-scale-set-controller/crds/actions.github.com_ephemeralrunnersets.yaml | Mirrors base CRD: adds Phase printer column. |
| charts/gha-runner-scale-set-controller/crds/actions.github.com_ephemeralrunners.yaml | Mirrors base CRD: renames column label to Phase. |
| charts/gha-runner-scale-set-controller/crds/actions.github.com_autoscalingrunnersets.yaml | Mirrors base CRD: .status.phase + Phase label. |
| charts/gha-runner-scale-set-controller-experimental/crds/actions.github.com_ephemeralrunnersets.yaml | Mirrors base CRD: adds Phase printer column. |
| charts/gha-runner-scale-set-controller-experimental/crds/actions.github.com_ephemeralrunners.yaml | Mirrors base CRD: renames column label to Phase. |
| charts/gha-runner-scale-set-controller-experimental/crds/actions.github.com_autoscalingrunnersets.yaml | Mirrors base CRD: .status.phase + Phase label. |
| apis/actions.github.com/v1alpha1/ephemeralrunnerset_types.go | Adds kubebuilder printcolumn for .status.phase. |
| apis/actions.github.com/v1alpha1/ephemeralrunner_types.go | Renames kubebuilder printcolumn name from Status to Phase. |
| apis/actions.github.com/v1alpha1/autoscalingrunnerset_types.go | Fixes kubebuilder printcolumn JSONPath to .status.phase and name to Phase. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4463