fix: make message parameters optional#404
Open
trueberryless wants to merge 3 commits intoactions:mainfrom
Open
fix: make message parameters optional#404trueberryless wants to merge 3 commits intoactions:mainfrom
trueberryless wants to merge 3 commits intoactions:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Aligns the runtime behavior of the first-interaction action with action.yml by treating issue_message and pr_message as optional inputs, preventing failures when only one message is configured (e.g., PR-only usage).
Changes:
- Remove
required: truefromissue_message/pr_messageinput retrieval. - Add early-exit “skip” behavior when the relevant message input is missing for the current event type.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
trueberryless
added a commit
to trueberryless/npmx-dev-npmx.dev
that referenced
this pull request
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
action.ymldefines both message parameters (issue_messageandpr_message) as not required. Therefore, those parameters should also not be required in the executing code, which otherwise results in an error:Related