Skip to content
This repository was archived by the owner on May 3, 2022. It is now read-only.

Comments

Update NPM packages + add 429 http code#14

Merged
konradpabjan merged 1 commit intomasterfrom
konradpabjan/misc-updates
Mar 27, 2020
Merged

Update NPM packages + add 429 http code#14
konradpabjan merged 1 commit intomasterfrom
konradpabjan/misc-updates

Conversation

@konradpabjan
Copy link
Contributor

@konradpabjan konradpabjan commented Mar 25, 2020

  • Add the 429 HTTP Code (copied over from the forked Microsoft Typed Rest Client). Will be needed because RU2 might return a 429 if there are too many calls being made and we get throttled.
  • Update NPM packages. Should get rid of the security warnings with the acorn package being out of date (see the dependabot PR Bump acorn from 5.7.3 to 5.7.4 #13) along with (most) of the problems that are showing up when running npm audit

@konradpabjan
Copy link
Contributor Author

Runs are still failing during npm audit, before my changes there were 37k vulnerabilities, now there is 1 (minimist), can't really go away because certain packages that have it as a dependency need to be updated upstream.

I used ncu to update all the packages: https://stackoverflow.com/questions/16073603/how-do-i-update-each-dependency-in-package-json-to-the-latest-version

@ericsciple
Copy link
Collaborator

ericsciple commented Mar 27, 2020

@bryanmacfarlane fyi since he will need to release

seems good to me

@bryanmacfarlane
Copy link
Member

LGTM

@konradpabjan konradpabjan merged commit b7761cf into master Mar 27, 2020
@ericsciple ericsciple deleted the konradpabjan/misc-updates branch March 27, 2020 21:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants