Fix action.yml snippets to replace typed text instead of inserting #307
Conversation
| // Get action scaffolding snippets if applicable | ||
| let actionSnippets: CompletionItem[] = []; | ||
| if (isAction && config?.featureFlags?.isEnabled("actionScaffoldingSnippets")) { | ||
| actionSnippets = getActionScaffoldingSnippets(parsedTemplate.value, path, position, replaceRange); |
There was a problem hiding this comment.
Moved down because it needs replaceRange
ericsciple
force-pushed
the
users/ericsciple/26-01-range
branch
from
b6b084c to
af7f08e
Compare
| path: TemplateToken[], | ||
| position: Position | ||
| position: Position, | ||
| replaceRange?: Range |
There was a problem hiding this comment.
plumbing replaceRange. Refer languageservice/src/complete.ts
There was a problem hiding this comment.
This is consistent with now non-snippet completion works
ericsciple
changed the title
There was a problem hiding this comment.
Pull request overview
Fixes action scaffolding snippet completions so selecting a snippet replaces the user’s already-typed text (prefix) instead of inserting the snippet after it.
Changes:
- Compute and pass a
replaceRangeinto action scaffolding snippet generation. - Update scaffolding snippet
textEditto useTextEdit.replace(...)when a replace range is available. - Add tests asserting scaffolding snippets replace typed prefixes.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| languageservice/src/complete.ts | Moves snippet generation to after replaceRange calculation and passes replaceRange into scaffolding snippet creation. |
| languageservice/src/complete-action.ts | Extends scaffolding snippet helpers to accept an optional replaceRange and uses it to create replace-vs-insert textEdits. |
| languageservice/src/complete-action.test.ts | Adds test coverage ensuring scaffolding snippets replace typed prefixes and handle empty-file scenarios. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| const [doc, position] = createActionDocument(`|`); | ||
| const completions = await complete(doc, position, scaffoldingConfig); | ||
|
|
||
| const compositeSnippet = completions.find(c => c.label === "Composite Action"); |
There was a problem hiding this comment.
In this test, compositeSnippet isn't asserted to exist before dereferencing textEdit.range, so a missing snippet will fail with a TypeError rather than a clear expectation failure. Add an explicit expect(compositeSnippet).toBeDefined() (or assert on compositeSnippet?.textEdit) before reading textEdit.range.* to improve debuggability.
| const compositeSnippet = completions.find(c => c.label === "Composite Action"); | |
| const compositeSnippet = completions.find(c => c.label === "Composite Action"); | |
| expect(compositeSnippet).toBeDefined(); |
No description provided.