Clean up feature flag actionScaffoldingSnippets
#309
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericsciple
changed the title
actionScaffoldingSnippets
ericsciple
force-pushed
the
users/ericsciple/26-01-clean
branch
from
c4ef29d to
e516513
Compare
ericsciple
commented
Jan 21, 2026
| # const greeting = \\\`Hello \\\${name}\\\`; | ||
| # console.log(greeting); | ||
| # fs.appendFileSync(process.env.GITHUB_OUTPUT, \\\`greeting=\\\${greeting}\\\\n\\\`); | ||
| # |
Collaborator
Author
There was a problem hiding this comment.
Redundant. This same comment is already included in the snippet on line 45
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request removes the actionScaffoldingSnippets experimental feature flag, making the action scaffolding snippets feature permanently enabled. The PR also cleans up redundant documentation comments in the Node.js action snippet template.
Changes:
- Removed feature flag check to make action scaffolding snippets always available in action files
- Cleaned up redundant documentation comments in action snippet templates
- Removed feature flag definition from the experimental features interface and related test expectations
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| languageservice/src/complete.ts | Removed feature flag conditional check, making action scaffolding snippets always enabled for action files |
| languageservice/src/complete-action.ts | Removed redundant documentation comment lines from Node.js action snippet template |
| languageservice/src/complete-action.test.ts | Removed FeatureFlags import, scaffoldingConfig constant, test for disabled feature flag, and updated all test calls to not pass config |
| expressions/src/features.ts | Removed actionScaffoldingSnippets property from ExperimentalFeatures interface and allFeatureKeys array |
| expressions/src/features.test.ts | Updated test expectations to exclude actionScaffoldingSnippets from the list of all enabled features |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
luketomlinson
approved these changes
Jan 21, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.