Remove allowServiceContainerCommand feature flag#345
Merged
ericsciple merged 1 commit intomainfrom Apr 3, 2026
Merged
Conversation
ericsciple
force-pushed
the
users/ericsciple/26-04-clean
branch
from
cf4a70e to
264e1ac
Compare
Service container entrypoint/command support is now unconditional.
ericsciple
force-pushed
the
users/ericsciple/26-04-clean
branch
from
264e1ac to
753a13a
Compare
ericsciple
commented
Apr 3, 2026
|
|
||
| ## Format | ||
|
|
||
| Always run formatting before committing: |
Collaborator
Author
There was a problem hiding this comment.
Hopefully will eliminate this friction in the future
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the allowServiceContainerCommand experimental feature flag and makes command/entrypoint support in service containers (jobs.<job_id>.services.*) unconditional.
Changes:
- Updated workflow template conversion to always parse service containers with
command/entrypointsupport. - Simplified language service tests by removing feature-flag configuration and validating the now-default behavior.
- Removed the feature flag definition and related test expectations from the expressions package; added contributor guidance in
AGENTS.md.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| workflow-parser/src/model/converter/container.ts | Removes flag gating so services always use convertToServiceContainer (enabling command/entrypoint). |
| languageservice/src/validate.service-container-command.test.ts | Removes feature-flag plumbing from tests; asserts default allow/deny behavior for service vs job containers. |
| expressions/src/features.ts | Deletes the allowServiceContainerCommand flag from the experimental feature set and key list. |
| expressions/src/features.test.ts | Updates expected enabled-feature lists after flag removal. |
| AGENTS.md | Adds repo-level build/test/format commands and documents the “remove flag when stable” process. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ericsciple
commented
Apr 3, 2026
| describe("with feature flag enabled", () => { | ||
| it("allows command in service container", async () => { | ||
| const input = ` | ||
| it("allows command in service container", async () => { |
Collaborator
Author
There was a problem hiding this comment.
For a better diff: Settings gear -> Hide whitespace
salmanmkc
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.