Skip to content

Improve retry handling based on feedback#1447

Merged
juliobbv merged 2 commits intomainfrom
users/juliobbv/improveRetry
Oct 29, 2021
Merged

Improve retry handling based on feedback#1447
juliobbv merged 2 commits intomainfrom
users/juliobbv/improveRetry

Conversation

@juliobbv
Copy link
Copy Markdown
Contributor

@juliobbv juliobbv commented Oct 29, 2021 •
edited
Loading

Follow up on #1385

Improve the PR in two ways:

  • Include how many runner attempts are left (as a URL query for easy tracking)
  • Add exponential backoff on the retry loop, to account for the two additional calls (so we don't end up with too many calls at once in case of an incident)

@juliobbv juliobbv requested a review from a team as a code owner October 29, 2021 17:24
TingluoHuang
TingluoHuang reviewed Oct 29, 2021
View reviewed changes
Comment thread src/Runner.Common/JobServer.cs Outdated
@juliobbv juliobbv merged commit b6dbf42 into main Oct 29, 2021
@juliobbv juliobbv deleted the users/juliobbv/improveRetry branch October 29, 2021 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TingluoHuang TingluoHuang TingluoHuang approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@juliobbv @TingluoHuang