Skip to content

fix: only show changed versions in node upgrade PR description#4332

Merged
salmanmkc merged 2 commits intomainfrom
fix/node-upgrade-pr-description
Apr 10, 2026
Merged

fix: only show changed versions in node upgrade PR description#4332
salmanmkc merged 2 commits intomainfrom
fix/node-upgrade-pr-description

Conversation

@salmanmkc
Copy link
Copy Markdown
Contributor

The node-upgrade.yml workflow always listed both Node 20 and Node 24 version transitions in the PR description and commit message, even when only one version actually changed. This produced confusing lines like:

  • Node 24: 24.14.0 → 24.14.0

(as seen in #4287)

This fix builds the commit message and PR body dynamically so only versions that actually changed are included.

@salmanmkc salmanmkc requested a review from a team as a code owner April 10, 2026 08:28
Copilot AI review requested due to automatic review settings April 10, 2026 08:28
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the scheduled Node version upgrade workflow to avoid generating noisy PR descriptions/commit messages when a Node major version didn’t actually change, improving signal in automated dependency PRs.

Changes:

  • Build a dynamic version summary for the commit message that includes only the versions that changed.
  • Build the PR body’s version bullet list dynamically so unchanged Node majors aren’t listed.
Show a summary per file
File Description
.github/workflows/node-upgrade.yml Dynamically constructs commit message + PR body version lines based on which Node majors require updates.

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 0

@salmanmkc salmanmkc enabled auto-merge (squash) April 10, 2026 08:40
@salmanmkc salmanmkc disabled auto-merge April 10, 2026 08:42
@salmanmkc salmanmkc merged commit 8d35e71 into main Apr 10, 2026
12 checks passed
@salmanmkc salmanmkc deleted the fix/node-upgrade-pr-description branch April 10, 2026 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants