Skip to content

Update setup job starting logs#4383

Merged
TingluoHuang merged 9 commits intoactions:mainfrom
GitPaulo:gitpaulo/update-setup-job-logs
May 4, 2026
Merged

Update setup job starting logs#4383
TingluoHuang merged 9 commits intoactions:mainfrom
GitPaulo:gitpaulo/update-setup-job-logs

Conversation

@GitPaulo
Copy link
Copy Markdown
Contributor

@GitPaulo GitPaulo commented Apr 28, 2026

Overview

We are cleaning up setup job logs and this is a first step to restore parity to LHR logs and improve on it further in the future.

Issue: https://github.com/github/hosted-compute/issues/3955

Copilot AI review requested due to automatic review settings April 28, 2026 11:04
@GitPaulo GitPaulo requested a review from a team as a code owner April 28, 2026 11:04
Co-authored-by: Copilot <copilot@github.com>
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the “Set up job” startup logging in JobExtension.InitializeJob to better align runner identification details (runner name, runner group) with the desired LHR/self-hosted log output.

Changes:

  • Log runner name unconditionally from runner settings.
  • Log runner group name based on configured pool metadata (PoolId / PoolName).
  • Keep machine name logging gated on detecting OAuth-based credentials.
Show a summary per file
File Description
src/Runner.Worker/JobExtension.cs Adjusts setup-job log lines for runner identity/group details.

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 3

Comment thread src/Runner.Worker/JobExtension.cs Outdated
Comment thread src/Runner.Worker/JobExtension.cs Outdated
Comment thread src/Runner.Worker/JobExtension.cs Outdated
Comment thread src/Runner.Worker/JobExtension.cs Outdated
GitPaulo and others added 2 commits April 28, 2026 12:15
Co-authored-by: Copilot <copilot@github.com>
Comment thread src/Runner.Worker/JobExtension.cs Outdated
Comment thread src/Runner.Worker/JobExtension.cs Outdated
@GitPaulo
Copy link
Copy Markdown
Contributor Author

Note: L0 tests are flaky, I can't re-run them as I'm committing from a fork. It should be 🆗 to ignore.

@GitPaulo GitPaulo requested a review from TingluoHuang May 4, 2026 10:20
@TingluoHuang TingluoHuang merged commit 16c8a91 into actions:main May 4, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants