Not retry and report action download 403.#4391
Merged
Merged
Conversation
TingluoHuang
commented
Apr 29, 2026
| } | ||
| } | ||
| catch (Exception ex) when (!(ex is OperationCanceledException) && !executionContext.CancellationToken.IsCancellationRequested) | ||
| catch (Exception ex) when (!(ex is AccessDeniedException) && !(ex is OperationCanceledException) && !executionContext.CancellationToken.IsCancellationRequested) |
Member
Author
There was a problem hiding this comment.
this will make sure we don't report the error to server.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the action archive download path in ActionManager to treat HTTP 403 (Forbidden) as a non-retryable failure, based on the assumption that it represents a client-side authorization/policy problem rather than a transient error.
Changes:
- Detect
HttpStatusCode.Forbiddenwhen downloading an action archive and throwAccessDeniedExceptionimmediately (no retry). - Add a dedicated
catch (AccessDeniedException)inside the retry loop for logging. - Adjust the outer exception filter to exclude
AccessDeniedExceptionfrom being wrapped.
Show a summary per file
| File | Description |
|---|---|
src/Runner.Worker/ActionManager.cs |
Adds explicit handling for 403 responses during action archive downloads to avoid retrying. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 4
salmanmkc
approved these changes
Apr 29, 2026
github-actions Bot
pushed a commit
to johngeorgewright/actions-runner
that referenced
this pull request
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
403 most likely client side error with auth or security setting, so retry won't help bypass them.