BrokerServer should not retry on 401.#4445
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Prevents the runner’s broker polling logic from retrying when authentication fails (HTTP 401), avoiding repeated retry loops on unauthorized responses.
Changes:
- Treat
VssUnauthorizedExceptionas non-retriable inBrokerServer.ShouldRetryException. - Update
.gitignoreto ignore*.lscachefiles (and normalize the existing*.DotSettings.userentry formatting).
Show a summary per file
| File | Description |
|---|---|
| src/Runner.Common/BrokerServer.cs | Stops retries when broker requests fail with VssUnauthorizedException (401). |
| .gitignore | Ignores .lscache artifacts and normalizes an existing ignore pattern line. |
Copilot's findings
- Files reviewed: 1/2 changed files
- Comments generated: 0
TingluoHuang
force-pushed
the
users/tihuang/401
branch
2 times, most recently
from
f6d1f63 to
fd13d1f
Compare
TingluoHuang
force-pushed
the
users/tihuang/401
branch
from
fd13d1f to
c59d781
Compare
rentziass
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.