Skip to content

Populate telemetry for non-action post-job steps#4463

Merged
TingluoHuang merged 2 commits into
actions:mainfrom
drielenr:telemetry-post-job-steps
May 28, 2026
Merged

Populate telemetry for non-action post-job steps#4463
TingluoHuang merged 2 commits into
actions:mainfrom
drielenr:telemetry-post-job-steps

Conversation

@drielenr
Copy link
Copy Markdown
Contributor

@drielenr drielenr commented May 28, 2026

Summary

Populate StepTelemetry.Type and StepTelemetry.Action for non-action post-job steps.

This is needed for snapshot requests, which are added as RegisterPostJobStep. Currently, action_execution_history telemetry type/action show as empty

issue:

Changes

  • Set Type = "runner" and derive Action from DisplayName for post-job steps

Before:
image

After:
image

Testing

  • Added RegisterPostJobStep_JobExtensionRunner_DefaultsRunnerTelemetry test to verify that runner-owned post-job steps get default telemetry values.
  • Added RegisterPostJobStep_ActionRunner_DoesNotOverrideTelemetry test to ensure that action post-job steps do not have their telemetry values pre-populated, allowing the handler to set them as needed.

@drielenr drielenr requested a review from a team as a code owner May 28, 2026 15:52
Copilot AI review requested due to automatic review settings May 28, 2026 15:52
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds default step telemetry for runner-owned post-job steps while ensuring action post-job steps keep handler-populated telemetry.

Changes:

  • Populate StepTelemetry.Type/Action when registering post-job steps that are not IActionRunner.
  • Add L0 coverage verifying defaults are applied for JobExtensionRunner and not applied for IActionRunner post steps.
Show a summary per file
File Description
src/Runner.Worker/ExecutionContext.cs Adds default telemetry assignment during RegisterPostJobStep for non-action steps.
src/Test/L0/Worker/ExecutionContextL0.cs Adds tests covering telemetry defaulting vs. non-overriding for action post steps.

Copilot's findings

  • Files reviewed: 2/2 changed files
  • Comments generated: 3

Comment thread src/Runner.Worker/ExecutionContext.cs
Comment thread src/Runner.Worker/ExecutionContext.cs
Comment thread src/Test/L0/Worker/ExecutionContextL0.cs
Comment thread src/Runner.Worker/ExecutionContext.cs Outdated
drielenr and others added 2 commits May 28, 2026 13:11
Co-authored-by: Tingluo Huang <tingluohuang@github.com>
@TingluoHuang TingluoHuang force-pushed the telemetry-post-job-steps branch from a8fcc4e to 5215c7e Compare May 28, 2026 17:11
@TingluoHuang TingluoHuang enabled auto-merge (squash) May 28, 2026 17:12
@TingluoHuang TingluoHuang merged commit c6a124e into actions:main May 28, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants