Populate telemetry for non-action post-job steps#4463
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds default step telemetry for runner-owned post-job steps while ensuring action post-job steps keep handler-populated telemetry.
Changes:
- Populate
StepTelemetry.Type/Actionwhen registering post-job steps that are notIActionRunner. - Add L0 coverage verifying defaults are applied for
JobExtensionRunnerand not applied forIActionRunnerpost steps.
Show a summary per file
| File | Description |
|---|---|
| src/Runner.Worker/ExecutionContext.cs | Adds default telemetry assignment during RegisterPostJobStep for non-action steps. |
| src/Test/L0/Worker/ExecutionContextL0.cs | Adds tests covering telemetry defaulting vs. non-overriding for action post steps. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 3
Co-authored-by: Tingluo Huang <tingluohuang@github.com>
a8fcc4e to
5215c7e
Compare
TingluoHuang
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Populate
StepTelemetry.TypeandStepTelemetry.Actionfor non-action post-job steps.This is needed for snapshot requests, which are added as
RegisterPostJobStep. Currently,action_execution_historytelemetry type/action show as emptyissue:
Changes
Type = "runner"and deriveActionfromDisplayNamefor post-job stepsBefore:

After:

Testing
RegisterPostJobStep_JobExtensionRunner_DefaultsRunnerTelemetrytest to verify that runner-owned post-job steps get default telemetry values.RegisterPostJobStep_ActionRunner_DoesNotOverrideTelemetrytest to ensure that action post-job steps do not have their telemetry values pre-populated, allowing the handler to set them as needed.