Skip to content

Conversation

@priya-kinthali
Copy link
Contributor

Description:
This PR updates the README to include a note for setting DOTNET_INSTALL_DIR to a user-writable path on self-hosted or large Linux runners, helping users avoid permission errors during .NET installation.

Related issue:
#518

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

Copilot AI review requested due to automatic review settings December 16, 2025 07:25
@priya-kinthali priya-kinthali requested a review from a team as a code owner December 16, 2025 07:25
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances the setup-dotnet action's documentation and improves the .NET installation scripts. It adds guidance for users experiencing permission issues on self-hosted Linux runners and includes maintenance updates to dependencies and installation scripts.

  • Added documentation explaining how to set DOTNET_INSTALL_DIR to user-writable paths for Linux runners with permission constraints
  • Updated js-yaml dependency from 3.14.1 to 3.14.2 and 4.1.0 to 4.1.1 in package-lock.json
  • Enhanced installation scripts with improved quoting, redirect handling, and spelling corrections

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

File Description
README.md Added documentation with examples for setting DOTNET_INSTALL_DIR and a note about permission issues on self-hosted/large Linux runners
package-lock.json Updated js-yaml dependency versions (3.14.1→3.14.2 and 4.1.0→4.1.1)
externals/install-dotnet.sh Improved shell script robustness with proper variable quoting, added -L flag to curl for following redirects, updated redirect validation to allow proxy-injected 200 status codes, and removed redundant Quality parameter documentation
externals/install-dotnet.ps1 Fixed spelling errors ("deterministicly"→"deterministically", "dowloading"→"downloading", "oververbose"→"verbose"), added -UseBasicParsing flag to Invoke-WebRequest, removed redundant Quality parameter documentation, and updated digital signature

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@priya-kinthali priya-kinthali self-assigned this Dec 16, 2025
@HarithaVattikuti HarithaVattikuti merged commit 937b8dd into actions:main Dec 22, 2025
106 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants