Updates 'setup-ruby' to v1 in the Jekyll Workflow Template#3296
Updates 'setup-ruby' to v1 in the Jekyll Workflow Template#3296eliduke wants to merge 2 commits into
Conversation
Recently started a new GitHub Pages / Jekyll project, and was surprised to see the setup-ruby action still tied to a very old and specific version. This is much cleaner now.
|
I had the same issues! The workflow is currently pinned to I tried upgrading incrementally:
So the minimum fix seems to be pinning to v1.177.0. We should also explicitly pin the runner to |
|
Is there a need to pin it to a specific version beyond just |
|
I think that error isn't so much with the version of setup-ruby as it is with the version of ruby--note on next line The action claims to support |
|
@evanwill Are you thinking to make some adjustments in this PR to address your issue #3329 ? The line in question here... starter-workflows/pages/jekyll.yml Line 40 in 1035244 The way that I read that and the comment included is that you need to remove the entire line for it to read from your - name: Setup Ruby
uses: ruby/setup-ruby@v1
with:
bundler-cache: true # runs 'bundle install' and caches installed gems automatically
cache-version: 0 # Increment this number if you need to re-download cached gemsThoughts? I think you are correct that we shouldn't have such an old version of ruby as the default here, but I'm not sure exactly what the default should be. |
|
I have been using Thanks on the .ruby-version file clarification--I just always figured if I had it .ruby-version it should override what is in the action, not that I would also have to comment it out! |
Recently started a new GitHub Pages / Jekyll project, and was surprised to see the
setup-rubyaction was still tied to a very old and specific version. Not sure why it's still held there, but I was getting some errors during my first couple deploys and I couldn't figure out what was going on!I upgraded a bunch of my own personal projects to v1 a while back, and I had just assumed that the Jekyll workflow template would have been updated as well.
Thoughts? Concerns?