Merged
Conversation
… English and Chinese
…d update conversion functions - Introduced MaintenancePeriods to the SqlQueryConfig struct for enhanced scheduling capabilities. - Updated conversion functions to include MaintenancePeriods when converting between biz and model representations. - Added logging for db service model conversion to assist in debugging.
PR Reviewer Guide 🔍(Review updated until commit e720440)
|
PR Code Suggestions ✨No code suggestions found for the PR. |
LordofAvernus
approved these changes
Mar 27, 2026
…integrate with CloudbeaverUsecase - Added MaintenanceTimeUsecase for managing maintenance time checks during SQL execution. - Integrated maintenance time checks into CloudbeaverUsecase's GraphQLDistributor method. - Updated SQLQueryConfig to include MaintenancePeriods for enhanced scheduling capabilities. - Introduced new methods for checking SQL execution permissions based on maintenance time configurations.
…beaverUsecase - Added MaintenanceTimeUsecase to manage maintenance time checks. - Updated CloudbeaverUsecase to include maintenance time in its initialization. - Refactored SQLQueryConfig handling to utilize new methods for maintenance time management. - Enhanced DMSService methods to convert and fill SQLQueryConfig with maintenance periods.
- Removed the DateTime definition from swagger.json and swagger.yaml. - Updated x-go-package references to point to the new common API path. - Added maintenance_times property to relevant definitions for enhanced maintenance time management.
f2dab88 to
e720440
Compare
|
Persistent review updated to latest commit e720440 |
|
Failed to generate code suggestions for PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
关联的 issue
https://github.com/actiontech/dms-ee/issues/762
描述你的变更
确认项(pr提交后操作)
Tip
请在指定复审人之前,确认并完成以下事项,完成后✅
not_compatibleneed_update_docDescription
添加运维时间管控逻辑检查
集成 MaintenanceTimeUsecase 至各服务
修改 SQLQueryConfig 支持 MaintenancePeriods 字段
更新 swagger、本地化及转换函数
Diagram Walkthrough
File Walkthrough
9 files
添加 maintenanceTimeUsecase 字段及检查逻辑更新 SQLQueryConfig 结构,加入 MaintenancePeriods 字段新增运维时间管控业务逻辑实现集成 MaintenanceTimeUsecase 至 Cloudbeaver 服务更新 API 转换逻辑及 SQLQueryConfig 填充调整 DBServiceSyncTask 转换以适配新配置集成 MaintenanceTimeUsecase 于 DMSService 中转换函数中增加对 MaintenancePeriods 字段的支持模型更新:新增 MaintenancePeriods 字段6 files
本地化配置中添加运维时间提示信息更新 swagger API 定义,新增 maintenance_times 字段swagger JSON 更新,移除 DateTime 定义并新增运维时间字段swagger YAML 更新,补充运维时间配置说明英文本地化中添加运维时间提示信息中文本地化中添加运维时间提示信息