Skip to content

fix: make password field optional when adding data source #601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LordofAvernus wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: make password field optional when adding data source #601

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions api/dms/service/v1/db_service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@ type DBService struct {
// Required: true
User string `json:"user" validate:"required"`
// DB Service admin password
// Required: true
Password string `json:"password" validate:"required"`
// Required: false
Password string `json:"password"`
// DB Service business name
// Required: true
// Deprecated: the business field is replaced with the environmentTag of the v2 interface.
Expand Down
4 changes: 2 additions & 2 deletions api/dms/service/v2/db_service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,8 +108,8 @@ type DBService struct {
// Required: true
User string `json:"user" validate:"required"`
// DB Service admin password
// Required: true
Password string `json:"password" validate:"required"`
// Required: false
Password string `json:"password"`
// DB Service environment tag
// Required: true
EnvironmentTagUID string `json:"environment_tag_uid" validate:"required"`
Expand Down