fix: excel format error, when the text is too long #2963
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ibility - Implement CSVBuilder struct with methods for creating CSV files - Add support for UTF-8 BOM and Excel cell character limit - Provide error handling for column count mismatch - Include example usage in the CSVBuilder type comment
- Remove direct usage of bytes.Buffer and csv.Writer - Introduce a new CSVBuilder utility for better CSV handling - Improve code readability and maintainability
- Remove direct usage of csv.Writer from the standard library - Introduce CSVBuilder from utils package to handle CSV creation - Update CSV export functions in audit_plan, instance_audit_plan, and rule controllers - Remove BOM writing as it's now handled by CSVBuilder
iwanghc
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
关联的 issue
https://github.com/actiontech/sqle-ee/issues/2250
test: https://github.com/actiontech/sqle-ee/issues/2250#issuecomment-2709866299
描述你的变更
确认项（pr提交后操作）
Tip
请在指定复审人之前，确认并完成以下事项，完成后✅
not_compatibleneed_update_doc