-
Notifications
You must be signed in to change notification settings - Fork 212
Issue 2962 #2992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Issue 2962 #2992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR Reviewer Guide 🔍(Review updated until commit b20a0ed)
|
PR Code Suggestions ✨No code suggestions found for the PR. |
|
Persistent review updated to latest commit b4a9779 |
PR Code Suggestions ✨No code suggestions found for the PR. |
|
Persistent review updated to latest commit 37b1753 |
PR Code Suggestions ✨No code suggestions found for the PR. |
|
Persistent review updated to latest commit b20a0ed |
PR Code Suggestions ✨No code suggestions found for the PR. |
LordofAvernus
approved these changes
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
关联的 issue
#2962
描述你的变更
mysql审核时删除sql语句的注释信息
确认项(pr提交后操作)
Tip
请在指定复审人之前,确认并完成以下事项,完成后✅
not_compatibleneed_update_docDescription
修复审核SQL以注释结尾时报错
优化日志输出,添加错误行信息
引入清除SQL注释的功能
增加相关单元测试
Changes walkthrough 📝
comment_cleaner.go
引入SQL注释清理功能sqle/driver/mysql/splitter/comment_cleaner.go
splitter.go
修改分割器以支持注释清理sqle/driver/mysql/splitter/splitter.go
splitter_test.go
增加SQL注释清理的测试sqle/driver/mysql/splitter/splitter_test.go