feat: add SQL Server support for terminate execution#3279
Merged
Conversation
When a SQL Server connection is KILLed during execution, the actual error returned via the C# gRPC plugin is "Timeout expired. The timeout period elapsed prior to completion of the operation or the server is not responding." rather than "connection is broken". Add this pattern to isConnectionTerminatedError() so terminated SQL is correctly identified. Fixes #2778
…#2778 SQL Server KILL causes the session to enter a kill state. Subsequent operations return "Cannot continue the execution because the session is in the kill state." which was not matched, leaving the task status as Execute failed instead of Termination success. Add strings.Contains match for "session is in the kill state" and corresponding test cases covering exec failed, exec batch failed, and tx failed gRPC wrappers.
BugsGuru
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isConnectionTerminatedError()for three error types: "connection is broken", "Timeout expired", and "session is in the kill state"Fixes actiontech/sqle-ee#2778
Test plan
isConnectionTerminatedError()pass (11 new SQL Server cases)