Tighten dependency version constraints to silence gem build warnings#13
Merged
Conversation
Open-ended `>= X.Y` constraints triggered rubygems build warnings
("if X is semantically versioned, use ~> X.Y"). Convert each
single-line floor to a pessimistic constraint or an explicit upper
bound where appropriate:
- devise, omniauth*, dev-only gems: `~> X.Y` (pessimistic — locks
to the major).
- rails: `>= 7.2, < 9` — must still allow Rails 8.
- omniauth_openid_connect: `>= 0.6, < 1` — 0.6.x ships
openid_connect 1.x (no faraday), 0.7.x+ ships 2.x (faraday 2.x);
both work, but staying inside 0.x avoids surprises if a 1.0 reshapes
the API.
- sqlite3 dev-dep: `>= 1.7, < 3` — sqlite3 2.x and 1.x both work
for the in-memory test DB; 3.x not yet vetted.
Fivell
added a commit
that referenced
this pull request
Jun 2, 2026
The previous `~> 1.0` constraint (from #13) blocked host apps that already shipped omniauth-rails_csrf_protection 2.0+. The 2.0 release dropped legacy Rails 4 support code but kept the OmniAuth API surface the gem uses, so both 1.x and 2.x are compatible. Bump to 2.1.2.
2 tasks
Fivell
added a commit
that referenced
this pull request
Jun 2, 2026
The previous `~> 1.0` constraint (from #13) blocked host apps that already shipped omniauth-rails_csrf_protection 2.0+. The 2.0 release dropped legacy Rails 4 support code but kept the OmniAuth API surface the gem uses, so both 1.x and 2.x are compatible. Bump to 2.1.2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Open-ended
>= X.Yconstraints triggered rubygems build warnings ("if X is semantically versioned, use~> X.Y"). Convert each single-line floor to a pessimistic constraint or an explicit upper bound where appropriate.devise,omniauth*, dev-only gems: pessimistic~> X.Y(locks to the major).rails:>= 7.2, < 9— keep Rails 8 in scope.omniauth_openid_connect:>= 0.6, < 1— both 0.6.x (openid_connect 1.x, no faraday) and 0.7.x+ (openid_connect 2.x, faraday 2.x) work; staying inside 0.x avoids surprises if a hypothetical 1.0 reshapes the API.sqlite3dev-dep:>= 1.7, < 3— sqlite3 1.x and 2.x both work for the in-memory test DB; 3.x not yet vetted.gem build activeadmin-oidc.gemspecnow produces no warnings.