add support of active admin v4#5
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds support for ActiveAdmin v4 by introducing version-aware behavior (notably around the Devise login view override) and updating development/CI dependency stacks so the gem can be exercised against both the AA 3.5 and AA 4.0 lines.
Changes:
- Add an
ActiveAdmin::Oidc.aa_v4?version probe and use it to select AA4-compatible Tailwind login markup. - Split dependency stacks into per-version gemfiles and update CI to run specs against both stacks via
BUNDLE_GEMFILE. - Broaden the gemspec ActiveAdmin dependency to
< 5and adjust ancillary repo config (.gitignore, Gemfile).
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| lib/generators/active_admin/oidc/install/templates/sessions_new.v4.html.erb | New AA4-tailored login view template (Tailwind markup). |
| lib/generators/active_admin/oidc/install/install_generator.rb | Selects which login view template to publish based on AA version. |
| lib/activeadmin-oidc.rb | Introduces aa_v4? helper for AA version detection. |
| gemfiles/activeadmin_4.0.gemfile | Defines the AA4/Rails 8/Tailwind development stack. |
| gemfiles/activeadmin_3.5.gemfile | Defines the AA3.5/Rails 7.2/Sprockets development stack. |
| Gemfile | Defaults local development to the AA3.5 gemfile via eval_gemfile. |
| app/views/active_admin/devise/sessions/new.html.erb | Runtime AA3 vs AA4 branching for the login page markup. |
| activeadmin-oidc.gemspec | Expands ActiveAdmin dependency to < 5; moves asset-stack deps out of gemspec. |
| .gitignore | Ignores gemfile lockfiles and additional dummy app temp/log paths. |
| .github/workflows/ci.yml | Switches CI to a gemfile-based matrix (AA3.5 + AA4.0). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
d2b2691 to
d1ad65a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.