fix: prepend view extensions at gem-require time, not via to_prepare#1
Merged
Conversation
`config.to_prepare` fires after the applications initializers, which is too late for consuming engines that require AA resource files from an initializer (a pattern AA permits via `config.load_paths`). Those resources see footer_data: silently no-op and the tfoot row never renders (or NameError when references to TableForExtension appear at registration time). Adopt the pattern used by sibling AA plugins (active_admin_sidebar, etc.): require "activeadmin" at the top of the gem's main file so `ActiveAdmin::Views` is guaranteed to exist, then eagerly prepend the extensions onto `TableFor` and `IndexAsTable`. The Engine class is kept (empty) so Rails still treats the gem as an engine on boot.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
config.to_preparefires after the applications initializers, which is too late for consuming engines that require AA resource files from an initializer (a pattern AA permits viaconfig.load_paths). Those resources see footer_data: silently no-op and the tfoot row never renders (or NameError when references to TableForExtension appear at registration time).Adopt the pattern used by sibling AA plugins (active_admin_sidebar, etc.): require "activeadmin" at the top of the gem's main file so
ActiveAdmin::Viewsis guaranteed to exist, then eagerly prepend the extensions ontoTableForandIndexAsTable. The Engine class is kept (empty) so Rails still treats the gem as an engine on boot.