Skip to content

Conversation

HusseinMorsy
Copy link

see discussion #3248

@dmitry
Copy link
Contributor

dmitry commented Jul 5, 2014

That's why I don't like when any assets are in the Gemfile (and bundled with the ruby code). In my opinion javascripts, stylesheets, fonts and images should attached to the rails engine as the vendor files.

@robertomiranda
Copy link

👍

@orendon
Copy link
Contributor

orendon commented Jul 7, 2014

👍

This patch should prevail over #3258 #3254 #3251 and #3248 imho

@robertomiranda
Copy link

@orendon right, I think this the best solution at the moment

@robertomiranda
Copy link

ref #3247

@seanlinsley
Copy link
Contributor

Unfortunately this doesn't actually work; ref sstephenson/sprockets#90

@robertomiranda
Copy link

seems that the solution is use require_asset instead of require ref https://github.com/sstephenson/sprockets/blob/master/lib/sprockets/context.rb#L121-L135

@seanlinsley
Copy link
Contributor

Right, except the order isn't preserved: sstephenson/sprockets#90 (comment)

@HusseinMorsy
Copy link
Author

@seanlinsley yes you are right. the solution doesn't work, because

  1. the directive preprocessor always runs before the erb engine.
  2. the require_asset ist not suitable, because require_asset is being added to the end of the list, instead of in the order of this file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants