Avoid duplicate work when downloading CSV #7336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deivid-rodriguez
force-pushed
the
no-dup-find-collection
branch
from
76a9495 to
b049c1b
Compare
|
Not sure how to get this tested. Only cucumber features have the proper setup to get this tested, but cucumber features are not supposed to verify this low level stuff. |
Fivell
reviewed
Feb 20, 2022
deivid-rodriguez
force-pushed
the
no-dup-find-collection
branch
from
b049c1b to
100c111
Compare
|
In the end I made a bigger refactor that allowed things to be more easily unit tested. |
|
Can you try this @senid231? |
deivid-rodriguez
changed the title
|
Let's try it! |
rylanb
reviewed
Jun 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7334.