fix rescue from load error in engine loading #416
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
This PR didn't work or brings new problems. I try to fix them and open a new PR later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There happens a strange error when Rails 5 is in use and a engine is used and a namespace which has no engine is used.
All this happens if you use Rails5, ActiveAdmin and the Knock or MailyHerald::Webui gem together.
Here is a App to reproduce the error: https://github.com/brentmulligan/aa-knock-issue
Stacktrace for the error: https://gist.github.com/brentmulligan/ad2ff32b27c3a20b0c9db8e5acd90ca7
(THX to @brentmulligan)
After some debugging I found out that this
rescuedon't capture the LoadError.related to: activeadmin/activeadmin#4532