Skip to content

Conversation

@sirwolfgang
Copy link
Contributor

No description provided.

Copilot AI review requested due to automatic review settings November 11, 2025 04:46
Copilot finished reviewing on behalf of sirwolfgang November 11, 2025 04:47
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds API key environment variables for Anthropic, OpenAI, and Open Router services to the documentation workflow. The changes also include a minor whitespace cleanup.

  • Added three API key environment variables (ANTHROPIC_API_KEY, OPEN_AI_API_KEY, OPEN_ROUTER_API_KEY) to the test environment
  • Removed trailing whitespace from the "Setup Ruby" step name

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

env:
RAILS_ENV: test
RAILS_MASTER_KEY: ${{ secrets.RAILS_MASTER_KEY }}
ANTHROPIC_API_KEY: ANTHROPIC_API_KEY
Copy link

Copilot AI Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The API key is set to the literal string "ANTHROPIC_API_KEY" instead of referencing a GitHub secret. It should be ${{ secrets.ANTHROPIC_API_KEY }} to properly inject the secret value, similar to how RAILS_MASTER_KEY is configured on line 58.

Suggested change
ANTHROPIC_API_KEY: ANTHROPIC_API_KEY
ANTHROPIC_API_KEY: ${{ secrets.ANTHROPIC_API_KEY }}

Copilot uses AI. Check for mistakes.
RAILS_ENV: test
RAILS_MASTER_KEY: ${{ secrets.RAILS_MASTER_KEY }}
ANTHROPIC_API_KEY: ANTHROPIC_API_KEY
OPEN_AI_API_KEY: OPEN_AI_API_KEY
Copy link

Copilot AI Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The API key is set to the literal string "OPEN_AI_API_KEY" instead of referencing a GitHub secret. It should be ${{ secrets.OPEN_AI_API_KEY }} to properly inject the secret value, similar to how RAILS_MASTER_KEY is configured on line 58.

Suggested change
OPEN_AI_API_KEY: OPEN_AI_API_KEY
OPEN_AI_API_KEY: ${{ secrets.OPEN_AI_API_KEY }}

Copilot uses AI. Check for mistakes.
RAILS_MASTER_KEY: ${{ secrets.RAILS_MASTER_KEY }}
ANTHROPIC_API_KEY: ANTHROPIC_API_KEY
OPEN_AI_API_KEY: OPEN_AI_API_KEY
OPEN_ROUTER_API_KEY: OPEN_ROUTER_API_KEY
Copy link

Copilot AI Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The API key is set to the literal string "OPEN_ROUTER_API_KEY" instead of referencing a GitHub secret. It should be ${{ secrets.OPEN_ROUTER_API_KEY }} to properly inject the secret value, similar to how RAILS_MASTER_KEY is configured on line 58.

Suggested change
OPEN_ROUTER_API_KEY: OPEN_ROUTER_API_KEY
OPEN_ROUTER_API_KEY: ${{ secrets.OPEN_ROUTER_API_KEY }}

Copilot uses AI. Check for mistakes.
@TonsOfFun TonsOfFun merged commit e0c40ba into activeagents:main Nov 11, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants