Skip to content

Fix-ollama-provider-stream-completion#318

Merged
TonsOfFun merged 2 commits intomainfrom
fix-ollama-provider-stream-completion
Feb 24, 2026
Merged

Fix-ollama-provider-stream-completion#318
TonsOfFun merged 2 commits intomainfrom
fix-ollama-provider-stream-completion

Conversation

@TonsOfFun
Copy link
Contributor

Add provider-level tests to prevent broadcast_stream_open from being accidentally removed. Tests verify:

  • :open event emits on first chunk
  • :update events emit for content
  • broadcast_stream_open is idempotent (only fires once)
  • :close event emits via process_prompt_finished
  • Full lifecycle order: open -> update(s) -> close
  • streaming flag state management

🤖 Generated with Claude Code
Co-authored-by: TheRealNeil TheRealNeil@users.noreply.github.com
Co-Authored-By: Claude noreply@anthropic.com

@superconductor-for-github
Copy link
Contributor

superconductor-for-github bot commented Feb 24, 2026

@TonsOfFunSuperconductor finishedView implementation | Guided Review


Standing by for instructions.

Add provider-level tests to prevent broadcast_stream_open from being
accidentally removed. Tests verify:

- :open event emits on first chunk
- :update events emit for content
- broadcast_stream_open is idempotent (only fires once)
- :close event emits via process_prompt_finished
- Full lifecycle order: open -> update(s) -> close
- streaming flag state management

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@TonsOfFun TonsOfFun force-pushed the fix-ollama-provider-stream-completion branch from aa38765 to d14536c Compare February 24, 2026 20:44
@TonsOfFun TonsOfFun merged commit 4d02fc5 into main Feb 24, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants