Fixed wheel build. #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khustup2
force-pushed
the
wheel-build-fix
branch
3 times, most recently
from
cd2c7f0 to
1a8d36d
Compare
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
khustup2
force-pushed
the
wheel-build-fix
branch
2 times, most recently
from
8f67c3e to
def3ced
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes wheel builds by implementing proper architecture-specific handling for cross-compilation and updating build configurations. The changes enable successful wheel builds on different platforms and architectures by correctly setting up vcpkg triplets, FFmpeg installations, and build environments.
- Adds vcpkg triplet configuration and cross-compilation setup for CMake
- Implements architecture-specific FFmpeg installations to avoid conflicts during cross-compilation
- Updates GitHub Actions workflow to support different runner types and properly configure platform-specific builds
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| cpp/CMakeLists.txt | Adds vcpkg triplet setup and cross-compilation verification |
| cmake/modules/findFFmpeg.cmake | Implements architecture-specific FFmpeg build directories and configuration |
| .github/workflows/wheel-build.yaml | Updates workflow to support flexible runners and platform-specific wheel builds |
activesoull
approved these changes
Aug 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.