Conversation
|
Claude finished @khustup2's task in 1m 9s —— View job PR Review CompleteFound 1 critical issue and 7 formatting issues - see inline comments for details. Critical:
Minor:
|
|
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
| false, | ||
| PGC_USERSET, | ||
| true, | ||
| PGC_POSTMASTER, |
There was a problem hiding this comment.
Critical: Breaking change - PGC_POSTMASTER restricts runtime configurability
Changing from PGC_USERSET to PGC_POSTMASTER means users can no longer change this setting per-session or even with ALTER SYSTEM. It now requires editing postgresql.conf and restarting the server. This is a major breaking change that should be:
- Clearly documented in the PR description
- Potentially reconsidered - should this be
PGC_SIGHUPinstead to allow reload without restart?
| PGC_POSTMASTER, | |
| PGC_SIGHUP, |
| @@ -323,7 +322,7 @@ async def test_stateless_data_sync_between_instances( | |||
| try: | |||
| # Setup extension (create if not exists for session-scoped instance reuse) | |||
| await conn_b.execute("CREATE EXTENSION IF NOT EXISTS pg_deeplake") | |||
There was a problem hiding this comment.
Formatting: Remove unnecessary blank line
Empty line left after removing stateless_enabled setting.
| await conn_b.execute("CREATE EXTENSION IF NOT EXISTS pg_deeplake") | |
| await conn_b.execute("CREATE EXTENSION IF NOT EXISTS pg_deeplake") | |
| @@ -412,7 +411,7 @@ async def test_stateless_concurrent_writes( | |||
| conn_b = await second_instance.connect() | |||
| try: | |||
| await conn_b.execute("CREATE EXTENSION IF NOT EXISTS pg_deeplake") | |||
There was a problem hiding this comment.
Formatting: Remove unnecessary blank line
Empty line left after removing stateless_enabled setting.
| await conn_b.execute("CREATE EXTENSION IF NOT EXISTS pg_deeplake") | |
| await conn_b.execute("CREATE EXTENSION IF NOT EXISTS pg_deeplake") | |
| @@ -515,7 +514,7 @@ async def test_stateless_multiple_tables_discovery( | |||
| conn_b = await second_instance.connect() | |||
| try: | |||
| await conn_b.execute("CREATE EXTENSION IF NOT EXISTS pg_deeplake") | |||
There was a problem hiding this comment.
Formatting: Remove unnecessary blank line
Empty line left after removing stateless_enabled setting.
| await conn_b.execute("CREATE EXTENSION IF NOT EXISTS pg_deeplake") | |
| await conn_b.execute("CREATE EXTENSION IF NOT EXISTS pg_deeplake") | |
| @@ -144,7 +143,7 @@ async def test_catalog_sync_default_schema( | |||
|
|
|||
| try: | |||
| await conn_b.execute("CREATE EXTENSION IF NOT EXISTS pg_deeplake") | |||
There was a problem hiding this comment.
Formatting: Remove unnecessary blank line
Empty line left after removing stateless_enabled setting.
| await conn_b.execute("CREATE EXTENSION IF NOT EXISTS pg_deeplake") | |
| await conn_b.execute("CREATE EXTENSION IF NOT EXISTS pg_deeplake") | |
| @@ -236,7 +235,7 @@ async def test_catalog_sync_multiple_reserved_schemas( | |||
|
|
|||
| try: | |||
| await conn_b.execute("CREATE EXTENSION IF NOT EXISTS pg_deeplake") | |||
There was a problem hiding this comment.
Formatting: Remove unnecessary blank line
Empty line left after removing stateless_enabled setting.
| await conn_b.execute("CREATE EXTENSION IF NOT EXISTS pg_deeplake") | |
| await conn_b.execute("CREATE EXTENSION IF NOT EXISTS pg_deeplake") | |
| @@ -322,7 +321,7 @@ async def test_catalog_sync_default_schema_with_indexes( | |||
|
|
|||
| try: | |||
| await conn_b.execute("CREATE EXTENSION IF NOT EXISTS pg_deeplake") | |||
There was a problem hiding this comment.
Formatting: Remove unnecessary blank line
Empty line left after removing stateless_enabled setting.
| await conn_b.execute("CREATE EXTENSION IF NOT EXISTS pg_deeplake") | |
| await conn_b.execute("CREATE EXTENSION IF NOT EXISTS pg_deeplake") | |
| @@ -378,7 +377,7 @@ async def test_catalog_sync_default_schema_write_from_secondary( | |||
|
|
|||
| try: | |||
| await conn_b.execute("CREATE EXTENSION IF NOT EXISTS pg_deeplake") | |||
There was a problem hiding this comment.
Formatting: Remove unnecessary blank line
Empty line left after removing stateless_enabled setting.
| await conn_b.execute("CREATE EXTENSION IF NOT EXISTS pg_deeplake") | |
| await conn_b.execute("CREATE EXTENSION IF NOT EXISTS pg_deeplake") | |
1 participant
🚀 🚀 Pull Request
Impact
Description
Things to be aware of
Things to worry about
Additional Context