Skip to content

fix(gmail): default Find Email to latest emails when no filters set#13124

Merged
hazemadelkhalel merged 3 commits intoactivepieces:mainfrom
sanket-a11y:feature/pie-300
May 6, 2026
Merged

fix(gmail): default Find Email to latest emails when no filters set#13124
hazemadelkhalel merged 3 commits intoactivepieces:mainfrom
sanket-a11y:feature/pie-300

Conversation

@sanket-a11y
Copy link
Copy Markdown
Collaborator

@sanket-a11y sanket-a11y commented May 6, 2026

Removes the throw that blocked Find Email when all properties were left empty,
omits the q parameter so Gmail returns the latest emails by default, and
lowers the default Max Results from 10 to 5. Updates the action description
and corresponding i18n key.

Fixes # (issue)

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 6, 2026

Confidence Score: 5/5

Safe to merge — the core behavioral change (allowing empty-filter searches) is correct and well-scoped.

The logic change is small and correct: removing the throw and conditionally omitting q is the right way to support empty searches against the Gmail API. The two remaining gaps (i18n key not swapped, default not lowered to 5) are cosmetic mismatches with the PR description rather than functional regressions.

The i18n locale files need the old description key replaced with the new one.

Important Files Changed

Filename Overview
packages/pieces/community/gmail/src/lib/actions/search-email-action.ts Removes the mandatory-filter guard and conditionally omits the q parameter so Gmail returns latest emails when no filters are set; description updated but max_results default (10) was not lowered to 5 as stated in the PR description, and the matching i18n keys were not updated.
packages/pieces/community/gmail/package.json Patch version bump from 0.12.2 to 0.12.3; no issues.

Reviews (2): Last reviewed commit: "Merge branch 'main' into feature/pie-300" | Re-trigger Greptile

@hazemadelkhalel hazemadelkhalel merged commit 236911f into activepieces:main May 6, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants