fix CUDA kernel syncthread usage #307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
ping @beomki-yeo |
Codecov Report
@@ Coverage Diff @@
## master #307 +/- ##
=======================================
Coverage 48.32% 48.32%
=======================================
Files 323 323
Lines 16376 16376
Branches 7603 7603
=======================================
Hits 7913 7913
Misses 3178 3178
Partials 5285 5285 Continue to review full report at Codecov.
|
Contributor
|
Thanks for the PR. |
Contributor
|
@cgleggett Could you update the PR to the latest master branch? |
msmk0
added
Impact - Major
msmk0
approved these changes
Jul 9, 2020
Contributor
msmk0
left a comment
msmk0
left a comment
There was a problem hiding this comment.
Thanks @cgleggett and thank @beomki-yeo for verifying. I will merge this in.
paulgessinger
pushed a commit
to paulgessinger/acts
that referenced
this pull request
Jul 13, 2020
Co-authored-by: leggett <leggett@cern.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
calling __syncthreads in a conditional that depends on the threadID results in undefined behaviour.
Interestingly, this wasn't apparent on older versions of the NVidia drivers, but is now.
Also, added option to SeedFinderCudaTest to not run on CPU, so as to test the GPU faster for large input files.