Skip to content

Conversation

@Corentin-Allaire
Copy link
Contributor

Fix an issue with the jsonToBinUtility. The bin the the json file can be 3 or 4 elements depending on if we read a geometry map or a material map.
The old code was causing segfault within athena, that issue will be solve by this PR.

@Corentin-Allaire Corentin-Allaire added Bug Something isn't working Component - Plugins Affects one or more Plugins Impact - Major Significant bug and/or affects a lot of modules labels Jul 24, 2020
@acts-issue-bot acts-issue-bot bot removed the Triage label Jul 24, 2020
@Corentin-Allaire Corentin-Allaire added this to the v0.30.00 milestone Jul 24, 2020
@codecov
Copy link

codecov bot commented Jul 24, 2020

Codecov Report

Merging #346 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #346   +/-   ##
=======================================
  Coverage   48.57%   48.57%           
=======================================
  Files         325      325           
  Lines       16356    16356           
  Branches     7588     7588           
=======================================
  Hits         7945     7945           
  Misses       3101     3101           
  Partials     5310     5310           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d53d17d...2372671. Read the comment docs.

@asalzburger
Copy link
Contributor

Ok, looks like we need to build 0.30.00 for Athena then.

@Corentin-Allaire
Copy link
Contributor Author

Ok, looks like we need to build 0.30.00 for Athena then.

It would be cleaner but for now I can go around the issue by modifying the json file used as input for the mapping. I just need to add a fourth elements to the bin object, something like that :
"bin0": [
"binPhi",
"closed",
24,
[0,0] <----- Added to the input json file for surface/volume mapped onto
],

@asalzburger asalzburger merged commit 75ac721 into acts-project:master Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working Component - Plugins Affects one or more Plugins Impact - Major Significant bug and/or affects a lot of modules

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants