refactor: Use templates where possible for compile-time checks and optimizations#4923
Merged
andiwand merged 2 commits intoacts-project:mainfrom Dec 20, 2025
Merged
refactor: Use templates where possible for compile-time checks and optimizations#4923andiwand merged 2 commits intoacts-project:mainfrom
andiwand merged 2 commits intoacts-project:mainfrom
Conversation
Member
|
/ci-bridge-run |
Member
|
@abarton5 Can you run pre-commit or clang-format locally? |
Contributor
abarton5
force-pushed
the
eigenstatic
branch
from
69d96c0 to
5f5dbf8
Compare
Contributor
Author
|
/ci-bridge-run |
1 similar comment
Member
|
/ci-bridge-run |
Member
|
@abarton5 there's a filter list for the CI command, fyi. I can add you to the list when I'm back in front of a computer. |
andiwand
approved these changes
Dec 20, 2025
Contributor
|
/ci-bridge-run |
|
Collaborator
acts-project-service
added
the
Fails Athena tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
perf: Use Eigen templates where possible (when matrix dimensions are known) for compile-time checks and optimizations
--- END COMMIT MESSAGE ---
Eigen's non-templated block(rows, cols, sizeRow, sizeCol) performs runtime size checks. Using the templated version block<SizeRows, SizeCols>(rows, cols) enforces sizes at compile time, which is more efficient and type-safe, especially for fixed-size operations on known vector columns.
This should not change any output.