Skip to content

docs: minor cmake option name correction#4928

Merged
kodiakhq[bot] merged 1 commit intoacts-project:mainfrom
veprbl:patch-4
Dec 21, 2025
Merged

docs: minor cmake option name correction#4928
kodiakhq[bot] merged 1 commit intoacts-project:mainfrom
veprbl:patch-4

Conversation

@veprbl
Copy link
Contributor

@veprbl veprbl commented Dec 21, 2025

--- END COMMIT MESSAGE ---
Accidentally stumbled on this while grepping the code.

Any further description goes here, @-mentions are ok here!

  • Use a conventional commits prefix: quick summary
    • We mostly use feat, fix, refactor, docs, chore and build types.
  • A milestone will be assigned by one of the maintainers

Accidentally stumbled on this while grepping the code.
Copilot AI review requested due to automatic review settings December 21, 2025 16:48
@github-actions github-actions bot added the Component - Documentation Affects the documentation label Dec 21, 2025
@github-actions github-actions bot added this to the next milestone Dec 21, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR corrects a documentation error where the CMake option for building the ONNX plugin was incorrectly referenced as ACTS_PLUGIN_ONNX instead of the correct -DACTS_BUILD_PLUGIN_ONNX=ON.

  • Corrects the CMake option name in the ONNX plugin documentation to match the actual option defined in CMakeLists.txt

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@kodiakhq kodiakhq bot merged commit 2922783 into acts-project:main Dec 21, 2025
39 checks passed
@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Dec 21, 2025
@andiwand andiwand modified the milestones: next, v45.0.0 Jan 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component - Documentation Affects the documentation Fails Athena tests This PR causes a failure in the Athena tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants