refactor: Refactoring of string parsing code for Gbts LUT and connection table by jpreston-cern · Pull Request #4934 · acts-project/acts

jpreston-cern · 2026-01-06T13:10:45Z

This is the first in a series of PR's that aim to bring GBTS up to date with ACTS coding standards.

This PR focuses on refactoring the parsing code for the LUT so that its in its own file mimicking that of the connector file as well as moving it to the constructor of GbtsSeedingAlgorithm. It also includes some code clean up, as well as moving the seedFinder constructor to initialize as well. This gives some speed increase due to not parsing the LUT every event.

--- END COMMIT MESSAGE ---

This will affect the Athena API but a branch is already ready to submit to the canary

@timadye @andiwand

github-actions · 2026-01-06T13:56:52Z

📊: Physics performance monitoring for `2fff28b`

Full contents

physmon summary

Core/include/Acts/Seeding/GbtsDataStorage.hpp

Core/include/Acts/Seeding/GbtsLutParser.hpp

Examples/Algorithms/TrackFinding/include/ActsExamples/TrackFinding/GbtsSeedingAlgorithm.hpp

Examples/Algorithms/TrackFinding/src/GbtsSeedingAlgorithm.cpp

jpreston-cern · 2026-01-07T23:49:46Z

i have added all the changes suggested so far, the only thing i was thinking was that as the shared pointer of both geometry and Lutparser (name to be changed) is first defined as a member function of SeedFinderGbts and is then passed in per instance of the createSeed function, if there is a lot of multi threading of events, would that cause slow down because of the atomic reference count being high/ changing a lot?

Core/include/Acts/Seeding/GbtsDataStorage.hpp

Core/include/Acts/Seeding/GbtsLutParser.hpp

Core/include/Acts/Seeding/SeedFinderGbts.hpp

andiwand · 2026-01-08T09:33:46Z

i have added all the changes suggested so far, the only thing i was thinking was that as the shared pointer of both geometry and Lutparser (name to be changed) is first defined as a member function of SeedFinderGbts and is then passed in per instance of the createSeed function, if there is a lot of multi threading of events, would that cause slow down because of the atomic reference count being high/ changing a lot?

GbtsDataStorage is only created once per event, no? this also contains the GbtsLutParser right now which is held by the std::shared_ptr. in this case I would not worry about performance in any way. there might be a bit more indirection but without detailed profiling this should be not acted on

in case this happens for every seed you might be able to see some performance effects but still I would expect it to be extremely small

jpreston-cern · 2026-01-08T18:19:10Z

I have added the parsing function to the SeedFinderGbts class which stores the parsed information as a member veriable, this is then passed to each instance of GbtsDataStorage . i thought this made the most sense due to the seed finder creating the instances of the GbtsDataStorage and already having a copy of the config, but i can move it if needed

andiwand · 2026-01-12T08:28:50Z

/ci-bridge-run

sonarqubecloud · 2026-01-12T09:25:20Z

Quality Gate passed

Issues
12 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

acts-project-service · 2026-01-12T11:14:57Z

🔴 Athena integration test results [`8f3a7cf`]

🔴 Some tests have failed!

Please investigate the pipeline!

status	job	report
🟢	report_pull_request
🟢	run_workflow_tests_run4_mc
🟢	run_workflow_tests_run2_mc
🟢	run_workflow_tests_run2_data
🟢	run_workflow_tests_run3_mc
🟢	run_workflow_tests_run3_data
🟢	test_ActsPersistifyEDM
🟢	test_ActsDumpGeometryIdentifiers
🔴	test_ActsCheckObjectCountsWorkflowHgtd
🔴	test_ActsCheckObjectCountsCachedWorkflow
🔴	test_ActsCheckObjectCountsLegacyWorkflow
🔴	test_ActsCheckObjectCountsWorkflow
🟢	test_ActsEFTrackFit
🟢	test_ActsPersistifySeeds
🟢	test_ActsBenchmarkWithSpot
🟢	test_ActsAnalogueClustering
🟢	test_ActsWorkflowHeavyIons
🟢	test_ActsWorkflowFastTracking
🔴	test_ActsWorkflowCached
🔴	test_ActsWorkflow
🟢	test_ActsValidateAmbiguityResolution
🟢	test_ActsValidateResolvedTracks
🟢	test_ActsValidateTracks
🟢	test_ActsValidateActsCoreSpacePoints
🟢	test_ActsValidateActsSpacePoints
🟢	test_ActsValidateSeeds
🟢	test_ActsValidateOrthogonalSeeds
🟢	test_ActsValidateClusters
🟢	test_ActsGx2fRefitting
🟢	test_ActsGSFRefitting
🔴	test_ActsKfRefitting
🟢	test_ActsExtrapolationAlgTest
🟢	test_ActsITkTest

timadye · 2026-01-12T11:29:37Z

Core/src/Seeding/GbtsDataStorage.cpp

-    : m_geo(geometry), m_config(config) {
+GbtsDataStorage::GbtsDataStorage(std::shared_ptr<const GbtsGeometry> geometry,
+                                 const SeedFinderGbtsConfig& config,
+                                 const GbtsMLLookupTable& parseLutFile)


parseLutFile → mlLUT, since this is the table itself, no longer the parser. Similarly in the .hpp file.

Sorry I missed this before (but anyway wouldn't want to hold up the merge). Maybe this can be included in a future PR.

to other thing would be to pass this by value, i.e. GbtsMLLookupTable mlLUT so the user can use std::move and avoid the copy

…ion table (acts-project#4934) This is the first in a series of PR's that aim to bring GBTS up to date with ACTS coding standards. This PR focuses on refactoring the parsing code for the LUT so that its in its own file mimicking that of the connector file as well as moving it to the constructor of GbtsSeedingAlgorithm. It also includes some code clean up, as well as moving the seedFinder constructor to initialize as well. This gives some speed increase due to not parsing the LUT every event.

jpreston-cern added 3 commits January 6, 2026 11:12

refactoring of LUT parser

302d8f6

removed unessicary include

16fe8ca

clang tidy

b2b27b8

github-actions bot added this to the next milestone Jan 6, 2026

github-actions bot added Component - Core Affects the Core module Component - Examples Affects the Examples module Seeding Track Finding labels Jan 6, 2026

jpreston-cern changed the title ~~Ref: Refactoring of string parsing code for LUT and connection table~~ refactor: Refactoring of string parsing code for LUT and connection table Jan 6, 2026

jpreston-cern changed the title ~~refactor: Refactoring of string parsing code for LUT and connection table~~ refactor: Refactoring of string parsing code for Gbts LUT and connection table Jan 6, 2026

add condition to pass empty array if clusterwidth is not used

09255a7

andiwand reviewed Jan 7, 2026

View reviewed changes

benjaminhuth reviewed Jan 7, 2026

View reviewed changes

Examples/Algorithms/TrackFinding/include/ActsExamples/TrackFinding/GbtsSeedingAlgorithm.hpp Show resolved Hide resolved

benjaminhuth reviewed Jan 7, 2026

View reviewed changes

Examples/Algorithms/TrackFinding/src/GbtsSeedingAlgorithm.cpp Outdated Show resolved Hide resolved

jpreston-cern added 2 commits January 7, 2026 19:30

fixes based of andi and benjamins suggestions

25854d6

clang tidy

17a22b0

andiwand reviewed Jan 8, 2026

View reviewed changes

jpreston-cern added 2 commits January 8, 2026 12:15

next set of changes (minus Lutparser conversation)

9b4c5bb

reformatted lut parser to be a free function instead of a class

ca2fd45

jpreston-cern marked this pull request as ready for review January 9, 2026 11:47

andiwand approved these changes Jan 12, 2026

View reviewed changes

andiwand added the automerge label Jan 12, 2026

Merge branch 'main' into refactoring

2fff28b

kodiakhq bot merged commit 8f3a7cf into acts-project:main Jan 12, 2026
44 checks passed

github-actions bot removed the automerge label Jan 12, 2026

acts-project-service added the Breaks Athena build This PR breaks the Athena build label Jan 12, 2026

timadye reviewed Jan 12, 2026

View reviewed changes

jpreston-cern deleted the refactoring branch January 13, 2026 11:22

jpreston-cern added a commit to jpreston-cern/acts that referenced this pull request Jan 13, 2026

changes based on extra comments on PR acts-project#4934

5b75c06

acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Jan 16, 2026

andiwand modified the milestones: next, v45.0.0 Jan 29, 2026

Conversation

jpreston-cern commented Jan 6, 2026 • edited by andiwand Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jan 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊: Physics performance monitoring for 2fff28b

physmon summary

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jpreston-cern commented Jan 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

andiwand commented Jan 8, 2026

Uh oh!

jpreston-cern commented Jan 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

andiwand commented Jan 12, 2026

Uh oh!

sonarqubecloud bot commented Jan 12, 2026

Quality Gate passed

Uh oh!

Uh oh!

acts-project-service commented Jan 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔴 Athena integration test results [8f3a7cf]

🔴 Some tests have failed!

Uh oh!

timadye Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

andiwand Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

jpreston-cern commented Jan 6, 2026 •

edited by andiwand

Loading

github-actions bot commented Jan 6, 2026 •

edited

Loading

📊: Physics performance monitoring for `2fff28b`

jpreston-cern commented Jan 7, 2026 •

edited

Loading

jpreston-cern commented Jan 8, 2026 •

edited

Loading

acts-project-service commented Jan 12, 2026 •

edited

Loading

🔴 Athena integration test results [`8f3a7cf`]